Skip to contentSkip to conversation

MTRR __initdata confusion.

PATCH Dave Jones 2 participants 2 messages Jul 3, 2004

lore
Share & tools
lore

Dave Jones

author
#0 lore raw

smp_changes_mask is used by generic_set_all() which isn't __init

Dave

arch/i386/kernel/cpu/mtrr/generic.c renamed from arch/i386/kernel/cpu/mtrr/generic.c~ +1 -1
@@ -18,7 +18,7 @@
 	mtrr_type def_type;
 };
 
-static unsigned long smp_changes_mask __initdata = 0;
+static unsigned long smp_changes_mask = 0;
 struct mtrr_state mtrr_state = {};
 
 
#1 lore raw

On Sat, 3 Jul 2004 17:41:43 +0100 Dave Jones wrote:

| smp_changes_mask is used by generic_set_all() which isn't __init
| 
| Signed-off-by: Dave Jones <[email protected]>
| 
| 		Dave
| 		
| --- FC2/arch/i386/kernel/cpu/mtrr/generic.c~	2004-07-03 17:40:00.408094696 +0100
| +++ FC2/arch/i386/kernel/cpu/mtrr/generic.c	2004-07-03 17:40:05.666295328 +0100
| @@ -18,7 +18,7 @@
|  	mtrr_type def_type;
|  };
|  
| -static unsigned long smp_changes_mask __initdata = 0;
| +static unsigned long smp_changes_mask = 0;
|  struct mtrr_state mtrr_state = {};

"= 0" can be dropped, as in the patch that I posted abour 2 weeks back:

http://marc.theaimsgroup.com/?l=linux-kernel&m=108727726300903&w=2

--
~Randy