Skip to contentSkip to conversation

fixes...

kernel26@ppc Paweł Sikora 4 participants 4 messages Jul 6, 2004 – Jul 9, 2004

Subsystems (4)
Media (V4L/DVB) SCSI Block layer IBM Power Linux RAID adapter
lore
Share & tools
lore

Paweł Sikora

author
#0 lore raw

Hi,
Could You look at attached patches?

[1] 2.6.7-ppc-asm-defs.patch
assembler reports an error at `dssall'

[2] 2.6.7-ppc-cciss-div.patch
a shift in sector_div() > bit-size of int.

[3] 2.6.7-ppc-ipr-div.patch
similar sector_div() bug.

[4] 2.6.7-ppc-saa7146-workaround.patch
is only workaround for a conflict:

"CC [M]  drivers/media/common/saa7146_video.o
drivers/media/common/saa7146_video.c:3: error: conflicting types for memory' include/asm-m68k/setup.h:365: error: previous declaration of memory'"

[5] 2.6.7-ppc-strncasecmp.patch
a confilct with strncasecmp in arch-ppc/lib/strcase.c

Signature · 3 lines
/* Copyright (C) 2003, SCO, Inc. This is valuable Intellectual Property. */

                           #define say(x) lie(x)
include/asm-ppc/ppc_asm.h renamed from include/asm-ppc/ppc_asm.h.orig +10 -0
@@ -73,6 +73,16 @@
 #define REST_16EVR(n,s,base)	REST_8EVR(n,s,base); REST_8EVR(n+8,s,base)
 #define REST_32EVR(n,s,base)	REST_16EVR(n,s,base); REST_16EVR(n+16,s,base)
 
+/*
+ * Once a version of gas that understands the AltiVec instructions
+  * is freely available, we can do this the normal way...  - paulus
+   */
+#define LVX(r,a,b)	.long	(31<<26)+((r)<<21)+((a)<<16)+((b)<<11)+(103<<1)
+#define STVX(r,a,b)	.long	(31<<26)+((r)<<21)+((a)<<16)+((b)<<11)+(231<<1)
+#define MFVSCR(r)	.long	(4<<26)+((r)<<21)+(770<<1)
+#define MTVSCR(r)	.long	(4<<26)+((r)<<11)+(802<<1)
+#define DSSALL		.long	(0x1f<<26)+(0x10<<21)+(0x336<<1)
+
 #ifdef CONFIG_PPC601_SYNC_FIX
 #define SYNC				\
 BEGIN_FTR_SECTION			\
drivers/block/cciss.c renamed from drivers/block/cciss.c.orig +2 -2
@@ -208,7 +208,7 @@
         ctlr_info_t *h = (ctlr_info_t*)data;
         drive_info_struct *drv;
 	unsigned long flags;
-	unsigned int vol_sz, vol_sz_frac;
+	uint64_t vol_sz, vol_sz_frac;
 
         ctlr = h->ctlr;
 

@@ -269,7 +269,7 @@
 		if (drv->raid_level > 5)
 			drv->raid_level = RAID_UNKNOWN;
 		size = sprintf(buffer+len, "cciss/c%dd%d:"
-				"\t%4d.%02dGB\tRAID %s\n",
+				"\t%4llu.%02lluGB\tRAID %s\n",
 				ctlr, i, vol_sz,vol_sz_frac,
 				raid_label[drv->raid_level]);
                 pos += size; len += size;
drivers/scsi/ipr.c renamed from drivers/scsi/ipr.c.orig +2 -1
@@ -2785,7 +2785,8 @@
 			 struct block_device *block_device,
 			 sector_t capacity, int *parm)
 {
-	int heads, sectors, cylinders;
+	int heads, sectors;
+	sector_t cylinders;
 
 	heads = 128;
 	sectors = 32;
drivers/media/common/saa7146_video.c renamed from drivers/media/common/saa7146_video.c.orig +6 -6
@@ -1,9 +1,9 @@
 #include <media/saa7146_vv.h>
 
-static int memory = 32;
+static int capmemory = 32;
 
-MODULE_PARM(memory,"i");
-MODULE_PARM_DESC(memory, "maximum memory usage for capture buffers (default: 32Mb)");
+MODULE_PARM(capmemory,"i");
+MODULE_PARM_DESC(capmemory, "maximum memory usage for capture buffers (default: 32Mb)");
 
 #define IS_CAPTURE_ACTIVE(fh) \
 	(((vv->video_status & STATUS_CAPTURE) != 0) && (vv->video_fh == fh))

@@ -1331,9 +1331,9 @@
 
 	*size = fh->video_fmt.sizeimage;
 
-	/* check if we exceed the "memory" parameter */
-	if( (*count * *size) > (memory*1048576) ) {
-		*count = (memory*1048576) / *size;
+	/* check if we exceed the "capmemory" parameter */
+	if( (*count * *size) > (capmemory*1048576) ) {
+		*count = (capmemory*1048576) / *size;
 	}
 
 	DEB_CAP(("%d buffers, %d bytes each.\n",*count,*size));
fs/gfs_locking/lock_gulm/utils_verb_flags.c renamed from fs/gfs_locking/lock_gulm/utils_verb_flags.c.orig +2 -0
@@ -20,6 +20,7 @@
 
 #include "gulm_log_msg_bits.h"
 
+#ifndef CONFIG_PPC
 static __inline__ int
 strncasecmp (const char *s1, const char *s2, size_t l)
 {

@@ -40,6 +41,7 @@
 	}
 	return (c1 - c2);
 }
+#endif
 
 static int bit_array[16] = { 0, 1, 1, 2, 1, 2, 2, 3, 1, 2, 2, 3, 2, 3, 3, 4 };
#1 lore raw
Quoted 5 lines · Paweł Sikora

Hi,
Could You look at attached patches?

[1] 2.6.7-ppc-asm-defs.patch
assembler reports an error at `dssall'

I think -Wa,-many for CFLAGS and AFLAGS will fix that, this has been discussed last week on this list.

Quoted 2 lines

[3] 2.6.7-ppc-ipr-div.patch
similar sector_div() bug.

you should send this to the driver maintainer,
Brian J King <[email protected]>

--
USB is for mice, FireWire is for men!

sUse lINUX ag, nÜRNBERG

** Sent via the linuxppc-dev mail list. See http://lists.linuxppc.org/

#2 lore raw
In reply to Paweł Sikora
Quoted 9 lines · Pawe? Sikora

[2] 2.6.7-ppc-cciss-div.patch
a shift in sector_div() > bit-size of int.

[3] 2.6.7-ppc-ipr-div.patch
similar sector_div() bug.

[4] 2.6.7-ppc-saa7146-workaround.patch
is only workaround for a conflict:

Quoted 6 lines

"CC [M] ?drivers/media/common/saa7146_video.o
drivers/media/common/saa7146_video.c:3: error: conflicting types for memory' include/asm-m68k/setup.h:365: error: previous declaration of memory'"

[5] 2.6.7-ppc-strncasecmp.patch
a confilct with strncasecmp in arch-ppc/lib/strcase.c

All of these should be sent to the respective driver maintainers.

--
Tom Rini
http://gate.crashing.org/~trini/

** Sent via the linuxppc-dev mail list. See http://lists.linuxppc.org/

#3 lore raw
Quoted 7 lines · Tom Rini
Quoted 6 lines · Pawe? Sikora

[4] 2.6.7-ppc-saa7146-workaround.patch
is only workaround for a conflict:

"CC [M] ?drivers/media/common/saa7146_video.o
drivers/media/common/saa7146_video.c:3: error: conflicting types for memory' include/asm-m68k/setup.h:365: error: previous declaration of memory'"

What kernel tree are you using that declares memory' in include/asm-m68k/setup.h? It's been called m68k_memory' since as far as I can remember...

Gr{oetje,eeting}s,

Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- [email protected]

In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds

** Sent via the linuxppc-dev mail list. See http://lists.linuxppc.org/