video/bttv-driver: replace
Subsystems (2)
PATCH 1/1 video/bttv-driver: replace
I would appreciate any comments from the janitors list. This is one (of many) cases where I made a decision about replacing
set_current_state(TASK_INTERRUPTIBLE);schedule_timeout(some_time);
with
msleep(jiffies_to_msecs(some_time));
msleep() is not exactly the same as the previous code, but I only did this replacement where I thought long delays were *desired*. If this is not the case here, then just disregard this patch.
Thanks,
Nish
Applys-to: 2.6.7
Description: Replace schedule_timeout() with msleep() to guarantee the task delays for the desired time.
Signed-off-by Nishanth Aravamudan <[email protected]>
drivers/media/video/bttv-driver.c +1 -2
@@ -743,8 +743,7 @@ static void set_pll(struct bttv *btv)for (i=0 ; i<10 ; i++) {/* Let other people run while the PLL stabilizes */ vprintk ("." ); -set_current_state (TASK_INTERRUPTIBLE ); -schedule_timeout (HZ /50 ); +msleep (20 );if (btread (BT848_DSTATUS ) &BT848_DSTATUS_PLOCK ) {btwrite (0 ,BT848_DSTATUS );
_______________________________________________
Kernel-janitors mailing list
[email protected]
http://lists.osdl.org/mailman/listinfo/kernel-janitors