Skip to contentSkip to conversation

hotplug/ibmphp: remove long_delay

PATCH Applied Nishanth Aravamudan 2 participants 4 messages Jul 27, 2004 – Aug 2, 2004

Subsystems (2)
Kernel janitors PCI
lore
Share & tools
lore

Nishanth Aravamudan

author
#0 lore raw

Sorry, I forgot the dependencies...

Applys-to: 2.6.7

Depends-on: Patches replacing long_delay() with msleep() in ibmphp_hpc.c and ibmphp_core.c.

Description: Remove long_delay().

Signed-off-by Nishanth Aravmudan <[email protected]>
drivers/pci/hotplug/ibmphp.h +0 -6
@@ -759,11 +759,5 @@ extern int ibmphp_configure_card (struct
 extern int ibmphp_unconfigure_card (struct slot **, int);
 extern struct hotplug_slot_ops ibmphp_hotplug_slot_ops;
 
-static inline void long_delay (int delay)
-{
-	set_current_state (TASK_INTERRUPTIBLE);
-	schedule_timeout (delay);
-}
-
 #endif				//__IBMPHP_H

_______________________________________________
Kernel-janitors mailing list
[email protected]
http://lists.osdl.org/mailman/listinfo/kernel-janitors

Applied
#1 lore raw

[Kernel-janitors] Re: [PATCH] hotplug/ibmphp_hpc: replace

Quoted 6 lines · Nishanth Aravamudan

I would appreciate any comments from the janitors list. This is one (of many) cases where I made a decision about replacing

set_current_state(TASK_INTERRUPTIBLE);
schedule_timeout(some_time);

Quoted 7 lines

with

msleep(jiffies_to_msecs(some_time));

msleep() is not exactly the same as the previous code, but I only did this replacement where I thought long delays were *desired*. If this is not the case here, then just disregard this patch.

Applied, thanks.

greg k-h

_______________________________________________
Kernel-janitors mailing list
[email protected]
http://lists.osdl.org/mailman/listinfo/kernel-janitors

Applied
#2 lore raw

[Kernel-janitors] Re: [PATCH] hotplug/ibmphp_core: replace

In reply to Nishanth Aravamudan
Quoted 6 lines · Nishanth Aravamudan

I would appreciate any comments from the janitors list. This is one (of many) cases where I made a decision about replacing

set_current_state(TASK_INTERRUPTIBLE);
schedule_timeout(some_time);

Quoted 7 lines

with

msleep(jiffies_to_msecs(some_time));

msleep() is not exactly the same as the previous code, but I only did this replacement where I thought long delays were *desired*. If this is not the case here, then just disregard this patch.

Applied, thanks.

greg k-h

_______________________________________________
Kernel-janitors mailing list
[email protected]
http://lists.osdl.org/mailman/listinfo/kernel-janitors