Skip to contentSkip to conversation

scsi/qla_init: replace schedule_timeout()

PATCH In review Nishanth Aravamudan 1 participant 2 messages Jul 27, 2004

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 scsi/qla_init: replace schedule_timeout()

I would appreciate any comments from the janitors list.

Applys-to: 2.6.7

Description: Use msleep() instead of schedule_timeout() to guarantee the task delays for the desired time.

drivers/scsi/qla2xxx/qla_init.c +1 -2
@@ -963,8 +963,7 @@ qla2x00_fw_ready(scsi_qla_host_t *ha)
 			break;
 
 		/* Delay for a while */
-		set_current_state(TASK_UNINTERRUPTIBLE);
-		schedule_timeout(HZ / 2);
+		msleep(2000);
 
 		DEBUG3(printk("scsi(%ld): fw_state=%x curr time=%lx.\n",
 		    ha->host_no, fw_state, jiffies));

_______________________________________________
Kernel-janitors mailing list
[email protected]
http://lists.osdl.org/mailman/listinfo/kernel-janitors

#1 lore raw

Re: [Kernel-janitors] [PATCH] scsi/qla_init: replace

Error in the patch, corrected below. Thanks, Domen.

Applys-to: 2.6.7

Description: Replaces schedule_timeout() with msleep() to guarantee task delays as desired.

drivers/scsi/qla2xxx/qla_init.c +1 -2
@@ -963,8 +963,7 @@ qla2x00_fw_ready(scsi_qla_host_t *ha)
 			break;
 
 		/* Delay for a while */
-		set_current_state(TASK_UNINTERRUPTIBLE);
-		schedule_timeout(HZ / 2);
+		msleep(500);
 
 		DEBUG3(printk("scsi(%ld): fw_state=%x curr time=%lx.\n",
 		    ha->host_no, fw_state, jiffies));

_______________________________________________
Kernel-janitors mailing list
[email protected]
http://lists.osdl.org/mailman/listinfo/kernel-janitors