scsi/sd: replace schedule_timeout() with
Subsystems (2)
PATCH 1/1 scsi/sd: replace schedule_timeout() with
I would appreciate any comments from the janitors list.
Applys-to: 2.6.7
Description: Use msleep() instead of schedule_timeout() to guarantee the task delays for the desired time.
Signed-off-by Nishanth Aravamudan <[email protected]>
drivers/scsi/sd.c +2 -6
@@ -49,6 +49,7 @@#include <linux/blkdev.h> #include <linux/blkpg.h> #include <linux/kref.h> +#include <linux/delay.h> #include <asm/uaccess.h> #include "scsi.h"
@@ -887,7 +888,6 @@ sd_spinup_disk(struct scsi_disk *sdkp, c* Issue command to spin up drive when not ready */ }else if (SRpnt->sr_sense_buffer[2 ] ==NOT_READY ) { -unsigned long time1;if (!spintime) {printk (KERN_NOTICE "%s: Spinning up disk..." , diskname);
@@ -906,12 +906,8 @@ sd_spinup_disk(struct scsi_disk *sdkp, c spintime_value = jiffies; } spintime =1 ; - time1 =HZ ;/* Wait 1 second for next try */ -do { - current->state =TASK_UNINTERRUPTIBLE ; - time1 =schedule_timeout (time1); - }while (time1); +msleep (1000 );printk ("." ); }else {/* we don't understand the sense code, so it's
_______________________________________________
Kernel-janitors mailing list
[email protected]
http://lists.osdl.org/mailman/listinfo/kernel-janitors