Skip to contentSkip to conversation

PATCH: Add support for Innovision DM-8401H

PATCH Alan Cox 2 participants 5 messages Jul 28, 2004

lore
Share & tools
lore

Alan Cox

author
#0 lore raw

This is an SII 680 with strange PCI identifiers it appears

Original patch: Alex Hewson
Verified by: Alan Cox <[email protected]>

OSDL Developer Certificate Of Origin included herein by reference

linux/pci_ids.h renamed from linux/pci_ids.h~ +1 -0
@@ -1634,6 +1634,7 @@
 #define PCI_VENDOR_ID_ITE		0x1283
 #define PCI_DEVICE_ID_ITE_IT8172G	0x8172
 #define PCI_DEVICE_ID_ITE_IT8172G_AUDIO 0x0801
+#define PCI_DEVICE_ID_ITE_DM8401	0x8212
 #define PCI_DEVICE_ID_ITE_8872		0x8872
 #define PCI_DEVICE_ID_ITE_IT8330G_0	0xe886
 
ide/pci/siimage.c renamed from ide/pci/siimage.c~ +6 -1
@@ -19,6 +19,8 @@
  *	If you have strange problems with nVidia chipset systems please
  *	see the SI support documentation and update your system BIOS
  *	if neccessary
+ *
+ *  17/06/2004: Added PCI ID's for Innovision DM-8401H card - [email protected]
  */
 
 #include <linux/config.h>
@@ -50,6 +52,7 @@
 		case PCI_DEVICE_ID_SII_1210SA:
 			return 1;
 		case PCI_DEVICE_ID_SII_680:
+		case PCI_DEVICE_ID_ITE_DM8401:
 			return 0;
 	}
 	BUG();
@@ -1108,7 +1111,8 @@
 static ide_pci_device_t siimage_chipsets[] __devinitdata = {
 	/* 0 */ DECLARE_SII_DEV("SiI680"),
 	/* 1 */ DECLARE_SII_DEV("SiI3112 Serial ATA"),
-	/* 2 */ DECLARE_SII_DEV("Adaptec AAR-1210SA")
+	/* 2 */ DECLARE_SII_DEV("Adaptec AAR-1210SA"),
+	/* 3 */ DECLARE_SII_DEV("InnoVISION DM8401H")
 };
 
 /**
@@ -1132,6 +1136,7 @@
 	{ PCI_VENDOR_ID_CMD, PCI_DEVICE_ID_SII_3112, PCI_ANY_ID, PCI_ANY_ID, 0, 0, 1},
 	{ PCI_VENDOR_ID_CMD, PCI_DEVICE_ID_SII_1210SA, PCI_ANY_ID, PCI_ANY_ID, 0, 0, 2},
 #endif
+	{ PCI_VENDOR_ID_ITE, PCI_DEVICE_ID_ITE_DM8401,  PCI_ANY_ID, PCI_ANY_ID, 0, 0, 3},
 	{ 0, },
 };
 MODULE_DEVICE_TABLE(pci, siimage_pci_tbl);
#1 lore raw

[ cc: linux-ide, please! ]

Quoted 1 line · Alan Cox

This is an SII 680 with strange PCI identifiers it appears

No, this is a different chipset (produced by ITE).

Quoted 2 lines

Original patch: Alex Hewson
Verified by: Alan Cox <[email protected]>

I asked you to compare Sil and ITE datasheets
(as I don't have one for Sil0680).

Have you done this?

linux/pci_ids.h line 1637

Quoted 5 lines
linux/pci_ids.h renamed from linux/pci_ids.h~ +1 -0
@@ -1634,6 +1634,7 @@
 #define PCI_VENDOR_ID_ITE		0x1283
 #define PCI_DEVICE_ID_ITE_IT8172G	0x8172
 #define PCI_DEVICE_ID_ITE_IT8172G_AUDIO 0x0801
+#define PCI_DEVICE_ID_ITE_DM8401	0x8212

This chipset is used by other cards as well.

ide/pci/siimage.c line 1116

Quoted 8 lines
ide/pci/siimage.c renamed from ide/pci/siimage.c~ +2 -1
@@ -1108,7 +1111,8 @@
 static ide_pci_device_t siimage_chipsets[] __devinitdata = {
 	/* 0 */ DECLARE_SII_DEV("SiI680"),
 	/* 1 */ DECLARE_SII_DEV("SiI3112 Serial ATA"),
-	/* 2 */ DECLARE_SII_DEV("Adaptec AAR-1210SA")
+	/* 2 */ DECLARE_SII_DEV("Adaptec AAR-1210SA"),
+	/* 3 */ DECLARE_SII_DEV("InnoVISION DM8401H")
 };

ditto

author
#2 lore raw
Quoted 3 lines · Bartlomiej Zolnierkiewicz
Quoted 1 line · Alan Cox

This is an SII 680 with strange PCI identifiers it appears

No, this is a different chipset (produced by ITE).

Ok then its a different chipset produced by ITE which appears to work perfectly with the SII driver, rather like the different chipset produced by Adaptec that is bug compatible and register identical with the SI3112

Quoted 4 lines

I asked you to compare Sil and ITE datasheets
(as I don't have one for Sil0680).

Have you done this?

I don't have the ITE datasheet.

Alan

#3 lore raw
Quoted 10 lines · Alan Cox
Quoted 4 lines · Bartlomiej Zolnierkiewicz
Quoted 1 line · Alan Cox

This is an SII 680 with strange PCI identifiers it appears

No, this is a different chipset (produced by ITE).

Ok then its a different chipset produced by ITE which appears to work perfectly with the SII driver, rather like the different chipset produced by Adaptec that is bug compatible and register identical with the SI3112

Quoted 6 lines
Quoted 4 lines

I asked you to compare Sil and ITE datasheets
(as I don't have one for Sil0680).

Have you done this?

I don't have the ITE datasheet.

google is your friend: "IT8212F .pdf"

author
#4 lore raw
Quoted 7 lines · Bartlomiej Zolnierkiewicz
Quoted 6 lines
Quoted 4 lines

I asked you to compare Sil and ITE datasheets
(as I don't have one for Sil0680).

Have you done this?

I don't have the ITE datasheet.

google is your friend: "IT8212F .pdf"

Ok the 8212F is different. Similar enough that the si680 driver would happen to work in a lot of cases but you are correct this patch should not go in.