Skip to contentSkip to conversation

net/seeq8005.c: small cleanups (fwd)

PATCH In review Adrian Bunk 2 participants 3 messages Aug 9, 2004 – Aug 11, 2004 Network drivers

lore
Share & tools
lore

Adrian Bunk

author
#0 lore raw

PATCH 1/1 net/seeq8005.c: small cleanups (fwd)

The trivial patch forwarded below still applies and compiles against 2.6.8-rc3-mm2.

Please apply.

----- Forwarded message from Adrian Bunk <[email protected]> -----

Date: Fri, 16 Jul 2004 00:17:42 +0200
From: Adrian Bunk <[email protected]>
To: [email protected]
Cc: [email protected], [email protected],
[email protected]
Subject: [2.6 patch] net/seeq8005.c: small cleanups

The patch below does the following small cleanups in seeq8005.c:
- kill ancient version variable
- remove Emacs settings

diffstat output:

 drivers/net/seeq8005.c |   18 ------------------
 1 files changed, 18 deletions(-)
Signed-off-by Adrian Bunk <[email protected]>
drivers/net/seeq8005.c renamed from drivers/net/seeq8005.c.old +0 -18
@@ -12,12 +12,7 @@
 	This file is a network device driver for the SEEQ 8005 chipset and
 	the Linux operating system.
 
-*/
-
-static const char version[] =
-	"seeq8005.c:v1.00 8/07/95 Hamish Coleman ([email protected])\n";
 
-/*
   Sources:
   	SEEQ 8005 databook
   	

@@ -150,7 +145,6 @@
 
 static int __init seeq8005_probe1(struct net_device *dev, int ioaddr)
 {
-	static unsigned version_printed;
 	int i,j;
 	unsigned char SA_prom[32];
 	int old_cfg1;

@@ -291,9 +285,6 @@
 	}
 #endif
 
-	if (net_debug  &&  version_printed++ == 0)
-		printk(version);
-
 	printk("%s: %s found at %#3x, ", dev->name, "seeq8005", ioaddr);
 
 	/* Fill in the 'dev' fields. */

@@ -757,12 +748,3 @@
 }
 
 #endif /* MODULE */
-
-/*
- * Local variables:
- *  compile-command: "gcc -D__KERNEL__ -I/usr/src/linux/net/inet -Wall -Wstrict-prototypes -O6 -m486 -c skeleton.c"
- *  version-control: t
- *  kept-new-versions: 5
- *  tab-width: 4
- * End:
- */

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

----- End forwarded message -----

#1 lore raw
Quoted 50 lines · Adrian Bunk

The trivial patch forwarded below still applies and compiles against 2.6.8-rc3-mm2.

Please apply.

----- Forwarded message from Adrian Bunk <[email protected]> -----

Date: Fri, 16 Jul 2004 00:17:42 +0200
From: Adrian Bunk <[email protected]>
To: [email protected]
Cc: [email protected], [email protected],
[email protected]
Subject: [2.6 patch] net/seeq8005.c: small cleanups

The patch below does the following small cleanups in seeq8005.c:
- kill ancient version variable
- remove Emacs settings

diffstat output:

 drivers/net/seeq8005.c |   18 ------------------
 1 files changed, 18 deletions(-)
Signed-off-by Adrian Bunk <[email protected]>
drivers/net/seeq8005.c renamed from drivers/net/seeq8005.c.old +0 -6
@@ -12,12 +12,7 @@
 	This file is a network device driver for the SEEQ 8005 chipset and
 	the Linux operating system.
 
-*/
-
-static const char version[] =
-	"seeq8005.c:v1.00 8/07/95 Hamish Coleman ([email protected])\n";
 
-/*
   Sources:
   	SEEQ 8005 databook
 

@@ -150,7 +145,6 @@
 
 static int __init seeq8005_probe1(struct net_device *dev, int ioaddr)
 {
-	static unsigned version_printed;
 	int i,j;
 	unsigned char SA_prom[32];
 	int old_cfg1;

drivers/net/seeq8005.c line 296

Quoted 6 lines
drivers/net/seeq8005.c renamed from drivers/net/seeq8005.c.old +0 -3
@@ -291,9 +285,6 @@
 	}
 #endif
 
-	if (net_debug  &&  version_printed++ == 0)
-		printk(version);
-

This "small cleanup" appears to kill useful and working code.

Jeff

author
#2 lore raw
Quoted 9 lines · Jeff Garzik

...

Quoted 3 lines
(quoted diff) +0 -2
-static const char version[] =
-	"seeq8005.c:v1.00 8/07/95 Hamish Coleman

([email protected])\n";

...

drivers/net/seeq8005.c line 295

Quoted 2 lines
drivers/net/seeq8005.c renamed from drivers/net/seeq8005.c.old +0 -2
-	if (net_debug  &&  version_printed++ == 0)
-		printk(version);

...
This "small cleanup" appears to kill useful and working code.

I'd agree if this was a version number that was regularly updated.

But when is a 9 year old version tag useful?

Quoted 1 line

Jeff

cu
Adrian

Signature · 4 lines
       "Is there not promise of rain?" Ling Tan asked suddenly out
        of the darkness. There had been need of rain for many days.
       "Only a promise," Lao Er said.
                                       Pearl S. Buck - Dragon Seed