Skip to contentSkip to conversation

Remove spaces from MTD pci_driver.name field

PATCH In review Deepak Saxena 2 participants 2 messages Aug 10, 2004 Memory technology devices (MTD)

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 Remove spaces from MTD pci_driver.name field

David,

Spaces in driver names show up as spaces in the sysfs tree. While there is no documented requirement that spaces not exist in sysfs paths, my understanding is that they are not desired.

Please apply,
~Deepak

===== drivers/mtd/maps/pci.c 1.6 vs edited =====

drivers/mtd/maps/pci.c +1 -1
@@ -362,7 +362,7 @@
 }
 
 static struct pci_driver mtd_pci_driver = {
-	.name =		"MTD PCI",
+	.name =		"MTD_PCI",
 	.probe =	mtd_pci_probe,
 	.remove =	__devexit_p(mtd_pci_remove),
 	.id_table =	mtd_pci_ids,

===== drivers/mtd/maps/scb2_flash.c 1.4 vs edited =====

drivers/mtd/maps/scb2_flash.c +1 -1
@@ -229,7 +229,7 @@
 };
 
 static struct pci_driver scb2_flash_driver = {
-	.name =     "Intel SCB2 BIOS Flash",
+	.name =     "Intel_SCB2_BIOS",
 	.id_table = scb2_flash_pci_ids,
 	.probe =    scb2_flash_probe,
 	.remove =   __devexit_p(scb2_flash_remove),
Signature · 4 lines
Deepak Saxena - dsaxena at plexity dot net - http://www.plexity.net/

"Unlike me, many of you have accepted the situation of your imprisonment and
 will die here like rotten cabbages." - Number 6
#1 lore raw

drivers/mtd/maps/scb2_flash.c line 232

Quoted 2 lines · Deepak Saxena
drivers/mtd/maps/scb2_flash.c +1 -1
-	.name =     "Intel SCB2 BIOS Flash",
+	.name =     "Intel_SCB2_BIOS",

This not only remove spaces (arguable) it also changes other parts of the naming.