Compile fixes for various fb drivers
Quoted 4 lines · you
Quoted 2 lines · Sebastian Kügler
fb_copy_cmaphas changed in 2.6.8.1 but the change is not reflected in all drivers, this updates the respective framebuffer drivers.
Quoted 8 lines
NAK.
First of all, that compile fix isn't - try to compile these drivers and see if any got fixed by that.
While we are at it, if they would compile, you would have broken them.
Question: what do you think the argument in question was controlling and why would "drop it silently" be a correct fix?
I thought that fb_copy_cmap would figure that out itself now, making the respective call in the driver less complicated, since the calls all looked the same which was a wrong assumption from my side.
Quoted 5 lines
And finally, the reason why these drivers would fail to compile for quite a while has a lot in common with the reason why they call
fb_copy_cmap()in the first place - they are trying to provide a method that doesn't exist anymore and calls in question are from the instances of that method. Fixing that is going to remove these calls anyway.
Hm, *a little* more complicated than I expected in the first place. I should have had a look at how other drivers handle that, the mere fact that the driver I am using myself was not in the list should've made me alert.
Anyway, sorry for the noise and thanks for having a look at it.
Signature · 6 lines
sebas - - - - - - - - - - - http://vizZzion.org ====================== Honest disagreement is often a good sign of progress. - Mahatma Gandhi (1869-1948)