PATCH: IDE - fix various comments remove never changing ifdef
No code changes in this patch just documenting
drivers/ide/ide.c +18 -9
@@ -347,10 +405,15 @@return system_bus_speed; } -/* -* current_capacity() returns the capacity (in sectors) of a drive -* according to its current geometry/LBA settings. +/** +* current_capacity - drive capacity +* @drive: drive to query +* +* Return the current capacity (in sectors) of a drive according to +* its current geometry/LBA settings. Empty removables are reported +* as size zero */ +sector_t current_capacity (ide_drive_t *drive) {if (!drive->present)
@@ -360,9 +423,17 @@EXPORT_SYMBOL (current_capacity); -/* -* Error reporting, in human readable form (luxurious, but a memory hog). +/** +* ide_dump_status - translate ATA error +* @drive: drive the error occured on +* @msg: information string +* @stat: status byte +* +* Error reporting, in human readable form (luxurious, but a memory hog). +* Combines the drive name, message and status byte to provide a +* user understandable explanation of the device error. */ +u8 ide_dump_status (ide_drive_t *drive,const char *msg,u8 stat) {ide_hwif_t *hwif =HWIF (drive);
@@ -371,7 +442,6 @@local_irq_set (flags);printk (KERN_WARNING "%s: %s: status=0x%02x" , drive->name, msg, stat); -#if FANCY_STATUS_DUMPS printk (" { " );if (stat &BUSY_STAT ) {printk ("Busy " );
@@ -385,12 +455,10 @@if (stat &ERR_STAT )printk ("Error " ); }printk ("}" ); -#endif /* FANCY_STATUS_DUMPS */ printk ("\n" );if ((stat & (BUSY_STAT |ERR_STAT )) ==ERR_STAT ) { err = hwif->INB (IDE_ERROR_REG );printk ("%s: %s: error=0x%02x" , drive->name, msg, err); -#if FANCY_STATUS_DUMPS if (drive->media == ide_disk) {printk (" { " );if (err &ABRT_ERR )printk ("DriveStatusError " );
@@ -434,7 +502,6 @@printk (", sector=%llu" , (unsigned long long )HWGROUP (drive)->rq->sector); } } -#endif /* FANCY_STATUS_DUMPS */ printk ("\n" ); }local_irq_restore (flags);
Quoted 1 line · Alan Cox
No code changes in this patch just documenting
If you want to remove FANCY_STATUS_DUMPS define please make a separate patch and remove it globally.
Quoted 5 lines · Bartlomiej Zolnierkiewicz
Quoted 1 line · Alan Cox
No code changes in this patch just documenting
If you want to remove
FANCY_STATUS_DUMPSdefine please make a separate patch and remove it globally.
Will do.