list_for_each: arch-alpha-kernel-pci.c

Quoted 3 lines · Domen Puncer

Hi.

Change for loops with list_for_each().

Please go directly to list_for_each_entry in all your patches where possible.

_______________________________________________
Kernel-janitors mailing list
[email protected]
http://lists.osdl.org/mailman/listinfo/kernel-janitors

Quoted 3 lines · Domen Puncer

Hi.

Change for loops with list_for_each().

Please go directly to list_for_each_entry in all your patches where possible.

_______________________________________________
Kernel-janitors mailing list
[email protected]
http://lists.osdl.org/mailman/listinfo/kernel-janitors

Quoted 5 lines · Christoph Hellwig

Quoted 3 lines · Domen Puncer

Hi.

Change for loops with list_for_each().

Quoted 1 line

Please go directly to list_for_each_entry in all your patches where possible.

Or are you implying that code like:

        list_for_each(ln, &bus->devices) {
                struct pci_dev *dev = pci_dev_b(ln);

could be list_for_each_entry, since pci_dev_b is basically a list_entry?

If that is the case, what was the reason for pci_dev_b in first place? More readability or maybe abstraction of pci code?