Skip to contentSkip to conversation

2.6.19-rc1 stv0299 fix

PATCH Jacek Popławski 2 participants 2 messages Aug 30, 2004 Media (V4L/DVB)

lore
Share & tools
lore
#0 lore raw

Hi!

I use SkyStar 2.6c DVB card. I noticed that I can't watch digital television anymore, after 2.6.7 to 2.6.9-rc1 upgrade. First reason was change of DVB device, but second one is little bug in kernel.

Name of device has been changed in 2.6.9-rc1 to "SkyStar2", but module stv0299 still compares name with "Technisat SkyStar2 driver", strings are different, and result is that stv0299 detects invalid tuner type. Not only I am not able to tune anything, but also I can crash system just by reloading DVB modules and being in X at same time.

Following obvious patch fixes problem.

drivers/media/dvb/frontends/stv0299.c +1 -1
@@ -1271,7 +1271,7 @@
 
 	printk ("%s: try to attach to %s\n", __FUNCTION__, adapter->name);
 
-	if ( strcmp(adapter->name, "Technisat SkyStar2 driver") == 0 )
+	if ( strcmp(adapter->name, "SkyStar2") == 0 )
 	{
 	    printk ("%s: setup for tuner Samsung TBMU24112IMB\n", __FILE__)
 
Signature · 4 lines
Free Software - find interesting programs and change them
NetHack - meet interesting creatures, kill them and eat their bodies
Usenet - meet interesting people from all over the world and flame them
Decopter - unrealistic helicopter simulator, get it from http://decopter.sf.net
#1 lore raw
Quoted 10 lines · Jacek Pop?awski

I use SkyStar 2.6c DVB card. I noticed that I can't watch digital television anymore, after 2.6.7 to 2.6.9-rc1 upgrade. First reason was change of DVB device, but second one is little bug in kernel.

Name of device has been changed in 2.6.9-rc1 to "SkyStar2", but module stv0299 still compares name with "Technisat SkyStar2 driver", strings are different, and result is that stv0299 detects invalid tuner type. Not only I am not able to tune anything, but also I can crash system just by reloading DVB modules and being in X at same time.

How so? What does the DVB driver have to do with X?

Quoted 1 line

Following obvious patch fixes problem.

Patch looks good. Please apply.

Johannes

drivers/media/dvb/frontends/stv0299.c +1 -1
@@ -1271,7 +1271,7 @@
 
 	printk ("%s: try to attach to %s\n", __FUNCTION__, adapter->name);
 
-	if ( strcmp(adapter->name, "Technisat SkyStar2 driver") == 0 )
+	if ( strcmp(adapter->name, "SkyStar2") == 0 )
 	{
 	    printk ("%s: setup for tuner Samsung TBMU24112IMB\n", __FILE__)