Skip to contentSkip to conversation

2.6.9-rc1-mm1 ppc build broken

DISCUSSION Albert Herranz 4 participants 7 messages Aug 30, 2004 – Sep 6, 2004

lore
Share & tools
lore
#0 lore raw

Hi,

It seems that the waitid-system-call.patch in 2.6.9-rc1-mm1 introduced a circular include dependency problem in the ppc arch.

The problem seems to be related to the addition of the linux/resource.h header file in include/asm-generic/siginfo.h for the new _rusage field.

CC arch/ppc/kernel/asm-offsets.s
In file included from include/linux/mm.h:4,
from include/asm/io.h:7, from include/linux/timex.h:61, from include/linux/time.h:29, from include/linux/resource.h:4, from include/asm-generic/siginfo.h:6, from include/asm/siginfo.h:4, from include/linux/signal.h:7, from
arch/ppc/kernel/asm-offsets.c:12:
include/linux/sched.h:276: error: field `shared_pending' has incomplete type include/linux/sched.h:379: error: parse error before "sigval_t"
include/linux/sched.h:379: warning: no semicolon at end of struct or union include/linux/sched.h:386: error: parse error before '}' token
include/linux/sched.h:534: error: RLIM_NLIMITS' undeclared here (not in a function) include/linux/sched.h:554: error: field pending' has incomplete type
include/linux/sched.h:587: error: parse error before "siginfo_t"
include/linux/sched.h:587: warning: no semicolon at end of struct or union include/linux/sched.h:607: error: parse error before '}' token
include/linux/sched.h: In function `process_group':
include/linux/sched.h:611: error: dereferencing pointer to incomplete type

Using gcc 3.3.2.
2.6.9-rc1, which does not include that patch, builds fine for me.

Any others saw this?

Cheers,
Albert

______________________________________________
Renovamos el Correo Yahoo!: ¡100 MB GRATIS! Nuevos servicios, más seguridad
http://correo.yahoo.es

#1 lore raw
Quoted 4 lines

The problem seems to be related to the addition of the linux/resource.h header file in include/asm-generic/siginfo.h for the new _rusage field.

This is creating a circularity on ppc that others don't have apparently.

Quoted 5 lines

CC arch/ppc/kernel/asm-offsets.s
In file included from include/linux/mm.h:4,

from include/asm/io.h:7,
from include/linux/timex.h:61,

This #include link here is the issue. Vanilla linux/timex.h does not have the #include <asm/io.h>. On other machines, <asm/io.h> does not include <linux/mm.h>, so you don't get into the problem with sched.h.

#2 lore raw
Quoted 9 lines

This is creating a circularity on ppc that others
don't have apparently.

Quoted 5 lines

CC arch/ppc/kernel/asm-offsets.s
In file included from include/linux/mm.h:4,

from include/asm/io.h:7,
from include/linux/timex.h:61,

Quoted 6 lines

This #include link here is the issue. Vanilla linux/timex.h does not have
the #include <asm/io.h>. On other machines, <asm/io.h> does not include
<linux/mm.h>, so you don't get into the problem with sched.h.

Thanks.

The #include <asm/io.h> comes from bk-ia64.patch time interpolation logic patch from Cristoph Lameter.

I've checked that at least for the embedded port I'm working on the linux/mm.h is *not* a must on ppc asm/io.h so we can get rid of it (commented out). Maybe this is also true for the rest of ppc platforms.

Now 2.6.9-rc1-mm1 builds fine.

Cheers,
Albert

______________________________________________
Renovamos el Correo Yahoo!: ¡100 MB GRATIS! Nuevos servicios, más seguridad
http://correo.yahoo.es

#3 lore raw

hOn Tue, Aug 31, 2004 at 12:51:18PM +0200, Albert Herranz wrote:

[[ CC'ing BenH since lists.linuxppc.org doesn't seem to resolve ]]

[ 2.6.9-rc1-mm1 ]

Quoted 21 lines
Quoted 9 lines

This is creating a circularity on ppc that others
don't have apparently.

Quoted 5 lines

CC arch/ppc/kernel/asm-offsets.s
In file included from include/linux/mm.h:4,

from include/asm/io.h:7,
from include/linux/timex.h:61,

Quoted 6 lines

This #include link here is the issue. Vanilla linux/timex.h does not have
the #include <asm/io.h>. On other machines, <asm/io.h> does not include
<linux/mm.h>, so you don't get into the problem with sched.h.

Thanks.

The #include <asm/io.h> comes from bk-ia64.patch time interpolation logic patch from Cristoph Lameter.

Quoted 6 lines

I've checked that at least for the embedded port I'm working on the linux/mm.h is *not* a must on ppc asm/io.h so we can get rid of it (commented out). Maybe this is also true for the rest of ppc platforms.

Now 2.6.9-rc1-mm1 builds fine.

This is still broken in -mm3. This fix works for my powermac too,
except that arch/ppc/syslib/open_pic.c misses errno.h when it does not get it through mm.h. I can't speak for other platforms, but I'll include the patch.

In case it matters:

--
Joseph Fannin
[email protected]

"That's all I have to say about that." -- Forrest Gump.

arch/ppc/syslib/open_pic.c +1 -0
diff -aurN a/arch/ppc/syslib/open_pic.c b/arch/ppc/syslib/open_pic.c
@@ -16,6 +16,7 @@
 #include <linux/irq.h>
 #include <linux/interrupt.h>
 #include <linux/sysdev.h>
+#include <linux/errno.h>
 #include <asm/ptrace.h>
 #include <asm/signal.h>
 #include <asm/io.h>
include/asm-ppc/io.h +0 -1
diff -aurN a/include/asm-ppc/io.h b/include/asm-ppc/io.h
@@ -4,7 +4,6 @@
 
 #include <linux/config.h>
 #include <linux/types.h>
-#include <linux/mm.h>
 
 #include <asm/page.h>
 #include <asm/byteorder.h>
#4 lore raw
Quoted 9 lines · [email protected] (Joseph Fannin) wrote:
Quoted 9 lines

The #include <asm/io.h> comes from bk-ia64.patch time interpolation logic patch from Cristoph Lameter.

I've checked that at least for the embedded port I'm working on the linux/mm.h is *not* a must on ppc asm/io.h so we can get rid of it (commented out). Maybe this is also true for the rest of ppc platforms.

Quoted 6 lines
Quoted 1 line

Now 2.6.9-rc1-mm1 builds fine.

This is still broken in -mm3. This fix works for my powermac too,
except that arch/ppc/syslib/open_pic.c misses errno.h when it does not get it through mm.h. I can't speak for other platforms, but I'll include the patch.

OK, now I have an ordering problem. If I understand you correctly, this patch fixes a ppc problem which was introduced by a patch from the bk-ia64 tree, yes?

If so, my options are to ask Tony to add this patch to the bk-ia64 tree so they all go in at the same time, or to merge this patch into Linus's tree prior to the ia64 patch. To do the latter, I'd need confirmation that your patch is safe against current -linus. Can you please confirm this?

arch/ppc/syslib/open_pic.c renamed from arch/ppc/syslib/open_pic.c~ppc-build-fix +1 -0
@@ -16,6 +16,7 @@
 #include <linux/irq.h>
 #include <linux/interrupt.h>
 #include <linux/sysdev.h>
+#include <linux/errno.h>
 #include <asm/ptrace.h>
 #include <asm/signal.h>
 #include <asm/io.h>
include/asm-ppc/io.h renamed from include/asm-ppc/io.h~ppc-build-fix +0 -1
diff -puN include/asm-ppc/io.h~ppc-build-fix include/asm-ppc/io.h
@@ -4,7 +4,6 @@
 
 #include <linux/config.h>
 #include <linux/types.h>
-#include <linux/mm.h>
 
 #include <asm/page.h>
 #include <asm/byteorder.h>

_

#5 lore raw
Quoted 10 lines · Andrew Morton
Quoted 4 lines · [email protected] (Joseph Fannin) wrote:

This is still broken in -mm3. This fix works for my powermac too,
except that arch/ppc/syslib/open_pic.c misses errno.h when it does not get it through mm.h. I can't speak for other platforms, but I'll include the patch.

OK, now I have an ordering problem. If I understand you correctly, this patch fixes a ppc problem which was introduced by a patch from the bk-ia64 tree, yes?

Yes.

Quoted 4 lines

If so, my options are to ask Tony to add this patch to the bk-ia64 tree so they all go in at the same time, or to merge this patch into Linus's tree prior to the ia64 patch. To do the latter, I'd need confirmation that your patch is safe against current -linus. Can you please confirm this?

-rc1-bk12 with this patch applied builds and runs okay on my
Powermac, so yes. Thanks!

Quoted 19 lines

+++ 25-akpm/arch/ppc/syslib/open_pic.c 2004-09-05 14:50:54.266081672 -0700

arch/ppc/syslib/open_pic.c renamed from arch/ppc/syslib/open_pic.c~ppc-build-fix +1 -0
@@ -16,6 +16,7 @@
 #include <linux/irq.h>
 #include <linux/interrupt.h>
 #include <linux/sysdev.h>
+#include <linux/errno.h>
 #include <asm/ptrace.h>
 #include <asm/signal.h>
 #include <asm/io.h>

diff -puN include/asm-ppc/io.h~ppc-build-fix include/asm-ppc/io.h
+++ 25-akpm/include/asm-ppc/io.h 2004-09-05 14:50:54.276080152 -0700

include/asm-ppc/io.h renamed from include/asm-ppc/io.h~ppc-build-fix +0 -1
@@ -4,7 +4,6 @@
 
 #include <linux/config.h>
 #include <linux/types.h>
-#include <linux/mm.h>
 
 #include <asm/page.h>
 #include <asm/byteorder.h>
Signature · 5 lines
Joseph Fannin
[email protected]

"Bull in pure form is rare; there is usually some contamination by data."
    -- William Graves Perry Jr.
#6 lore raw
Quoted 8 lines
Quoted 1 line

OK, now I have an ordering problem. If I

understand you correctly, this

Quoted 1 line

patch fixes a ppc problem which was introduced by

a patch from the bk-ia64

Quoted 1 line

tree, yes?

Yes.

As I understand it, the build problem was triggered when the waitid-system-call.patch from Roland McGrath and the bk-ia64.patch time interpolation logic patch from Cristoph Lameter were applied.

But the cause itself, as Roland pointed, is the fact that the asm-ppc/io.h includes linux/mm.h, unlike other platforms (that's why the build problem only affected ppc).
This seems to be unnecessary. At least, confirmation for this exists for some embedded ppc ports (me) and the PowerMac (Joseph).

Quoted 4 lines
Quoted 1 line

If so, my options are to ask Tony to add this

patch to the bk-ia64 tree so

Quoted 1 line

they all go in at the same time, or to merge this

patch into Linus's tree

Quoted 9 lines
Quoted 1 line

prior to the ia64 patch. To do the latter, I'd

need confirmation that your

Quoted 1 line

patch is safe against current -linus. Can you

please confirm this?

-rc1-bk12 with this patch applied builds and
runs okay on my
Powermac, so yes. Thanks!

IIRC, the linus tree also includes linux/mm.h in asm-ppc/io.h since several versions.

Cheers,
Albert

______________________________________________
Renovamos el Correo Yahoo!: ¡100 MB GRATIS! Nuevos servicios, más seguridad
http://correo.yahoo.es