Skip to contentSkip to conversation

RCU callback and scheduling while atomic!

DISCUSSION Herbert Poetzl 2 participants 3 messages Aug 31, 2004 – Sep 6, 2004

lore
Share & tools
lore
#0 lore raw

Hi Dipankar!
Hi Rusty!

just a short question regarding RCU callbacks:

it seems that the RCU callback is not allowed to (re-)schedule, as it is done occasionally by put_namespace() for example, as I keep getting "bad: scheduling while atomic!", when I do so ...

now the question: what is the 'correct' way to drop a reference to a namespace when freeing up a structure from an RCU callback?

TIA,
Herbert

#1 lore raw
Quoted 9 lines · Herbert Poetzl

it seems that the RCU callback is not allowed to (re-)schedule, as it is done occasionally by put_namespace() for example, as I keep getting "bad: scheduling while atomic!", when I do so ...

now the question: what is the 'correct' way to drop a reference to a namespace when freeing up a structure from an RCU callback?

You are right about not allowing schedule from callbacks. The callbacks are called from softirq context.

Without your current code, it is difficult to say how to do this but here are some guesses -

1. You could mark the freed up structure deleted on update, do put_namspace() and do only the freeing in the rcu callback. dentries do this.

2. If not performance critical, you could use a workqueue to do the actual freeing including put_namespace(). Just wake up from the rcu callback.

These may or may not be applicable to your case. More details will help.

Thanks
Dipankar

#2 lore raw
Quoted 17 lines · Dipankar Sarma
Quoted 9 lines · Herbert Poetzl

it seems that the RCU callback is not allowed to (re-)schedule, as it is done occasionally by put_namespace() for example, as I keep getting "bad: scheduling while atomic!", when I do so ...

now the question: what is the 'correct' way to drop a reference to a namespace when freeing up a structure from an RCU callback?

You are right about not allowing schedule from callbacks. The callbacks are called from softirq context.

Without your current code, it is difficult to say how to do this but here are some guesses -

Quoted 7 lines

1. You could mark the freed up structure deleted on update, do put_namspace() and do only the freeing in the rcu callback. dentries do this.

2. If not performance critical, you could use a workqueue to do the actual freeing including put_namespace(). Just wake up from the rcu callback.

ah, okay, I see, although it isn't time critical,
it seems to me that the first is the best choice
in my case, thanks for the hints ...

Quoted 2 lines

These may or may not be applicable to your case. More details will help.

thanks,
Herbert

Quoted 7 lines

Thanks
Dipankar
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/