Skip to contentSkip to conversation

ACPI-based i8042 keyboard/aux controller enumeration

PATCH In review Bjorn Helgaas 2 participants 2 messages Sep 2, 2004

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 ACPI-based i8042 keyboard/aux controller enumeration

This is based on 2.6.9-rc1-mm2, i.e., it applies after bk-acpi.patch, bk-input.patch, and fix-smm-failures-on-e750x-systems.patch from -mm2.

Add ACPI-based i8042 keyboard and aux controller enumeration.

This can be disabled with "i8042.no_acpi=1". If you need to disable it, please let me know so I can fix it.

The main reason we need this is because i8042_check_aux() does a request_irq(12) before it knows whether the AUX controller is even present. Some boards with a keyboard controller but no AUX controller reuse IRQ 12 for PCI interrupts. And apparently the BIOS on some of those boards leaves IRQ 12 programmed as edge-triggered, active high, even though the PCI interrupt is level-triggered, active low. So if i8042 comes along and requests IRQ 12 before the PCI driver enables the device and programs the IOAPIC correctly, i8042 gets an endless stream of interrupts.

This patch avoids that situation by only poking at ports that ACPI tells us about. If ACPI doesn't tell us about an AUX controller, we don't touch IRQ 12.

Documentation/kernel-parameters.txt +1 -0
diff -u -ur 2.6.9-rc1-mm2-kbd1/Documentation/kernel-parameters.txt 2.6.9-rc1-mm2-kbd2/Documentation/kernel-parameters.txt
@@ -469,6 +469,7 @@
 			     controller
 	i8042.reset	[HW] Reset the controller during init and cleanup
 	i8042.unlock	[HW] Unlock (ignore) the keylock
+	i8042.no_acpi=1	[HW] Don't use ACPI to discover KBD/AUX ports
 
 	i810=		[HW,DRM]
 
drivers/input/serio/i8042.c +150 -0

174 lines not on this page · raw message

#1 lore raw
Quoted 1 line · Bjorn Helgaas

Add ACPI-based i8042 keyboard and aux controller enumeration.

You should probably also add the same for the non-ACPI path with the BIOS feature word query stuff in this case ?