Intel ICH - sound/pci/intel8x0.c
Quoted 4 lines · Jon Smirl
The joystick PCI ID table in
intel8x0.cis not correct. Joysticks and MIDI ports are ISA devices and need be located by manual probing. This ID table needs to be removed. Joystick and MIDI ports do not have PCI IDs.
I agree, that was I explain in a previous post
(http://marc.theaimsgroup.com/?l=linux-kernel&m=109420281830288&w=2)
see the PS.
Quoted 8 lines
It isn't that simple. The LPC bridge also contains the controls for the
joystick ports. You also need them for hotplug handling of the bridge should someone stick one in a laptop docking station. The ID table also
ensures the driver is loaded. It's probably true that it will need splitting up a bit if another driver also needs ownership of the LPC bridge but for now that hasn't happened.
Not for jostick and midi stuff you have to use pnp bus.
On my computer it works well :
I have removed the support of MIDI and GAMEPORT in alsa driver. The gameport is handle with ns558
The midi device with a mpu401_pnp I post on the alsa mailling list
(http://sourceforge.net/mailarchive/forum.php?thread_id=5468125&forum_id=1751)
For that it work well you need a pnpbios patch
(http://marc.theaimsgroup.com/?l=linux-kernel&m=109411306024720&w=2) or even try to use my pnpacpi patch
(http://marc.theaimsgroup.com/?l=linux-kernel&m=109430451522335&w=2)
And the isapnp hotplug script auto load the right module...
Regards,
Matthieu
I'd don't know enough about the LPC bridge chip to know what the correct answer is for this. Right now I tend to think that the PCI driver should own the bridge chip. If not the PCI driver then there should be an explicit bridge driver. I don' think it is correct that a joystick driver is attaching to a bridge chip given the simple fact that all legacy IO - joystick, PS/2, parallel, serial, etc is located off from that same bridge chip.
Matthieu's comments about using PNP for this seem to make sense. Are we missing implementation of an ACPI feature for controlling these ports?
Quoted 40 lines · Matthieu Castet
Quoted 4 lines · Jon Smirl
The joystick PCI ID table in
intel8x0.cis not correct. Joysticks and MIDI ports are ISA devices and need be located by manual probing. This ID table needs to be removed. Joystick and MIDI ports do not have PCI IDs.I agree, that was I explain in a previous post
(http://marc.theaimsgroup.com/?l=linux-kernel&m=109420281830288&w=2)
see the PS.Quoted 8 lines
It isn't that simple. The LPC bridge also contains the controls for the
joystick ports. You also need them for hotplug handling of the bridge should someone stick one in a laptop docking station. The ID table also
ensures the driver is loaded. It's probably true that it will need splitting up a bit if another driver also needs ownership of the LPC bridge but for now that hasn't happened.Not for jostick and midi stuff you have to use pnp bus.
On my computer it works well :
I have removed the support of MIDI and GAMEPORT in alsa driver. The gameport is handle with ns558
The midi device with ampu401_pnpI post on the alsa mailling list
(http://sourceforge.net/mailarchive/forum.php?thread_id=5468125&forum_id=1751)
For that it work well you need a pnpbios patch
(http://marc.theaimsgroup.com/?l=linux-kernel&m=109411306024720&w=2) or even try to use my pnpacpi patch
(http://marc.theaimsgroup.com/?l=linux-kernel&m=109430451522335&w=2)
And the isapnp hotplug script auto load the right module...Regards,
Matthieu
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Signature · 2 lines
Jon Smirl [email protected]
Quoted 5 lines · Jon Smirl
I'd don't know enough about the LPC bridge chip to know what the correct answer is for this. Right now I tend to think that the PCI driver should own the bridge chip. If not the PCI driver then there should be an explicit bridge driver. I don' think it is correct that a joystick driver is attaching to a bridge chip given the simple fact
Nobody else currently needs to attach to it so why make life needlessly complicated.
Quoted 6 lines
that all legacy IO - joystick, PS/2, parallel, serial, etc is located off from that same bridge chip.
Matthieu's comments about using PNP for this seem to make sense. Are we missing implementation of an ACPI feature for controlling these ports?
See previous discussion. We have isapnp, biospnp but not great acpi pnp. None of them help because you need to deal with hotplug.
Alan
On Sun, 05 Sep 2004 21:49:50 +0100 Alan Cox wrote:
| On Sul, 2004-09-05 at 22:24, Jon Smirl wrote: | > I'd don't know enough about the LPC bridge chip to know what the | > correct answer is for this. Right now I tend to think that the PCI | > driver should own the bridge chip. If not the PCI driver then there | > should be an explicit bridge driver. I don' think it is correct that a | > joystick driver is attaching to a bridge chip given the simple fact | | Nobody else currently needs to attach to it so why make life needlessly | complicated.
What I/O addresses are we talking about here?
There is someone working on a SD/MMC (blah blah) memory card interface that is on LPC, using what used to be reserved as timer IO ports (0x40 - 0x5f), and he's splitting timer ports up into 2 ranges:0x40 - 0x43 and 0x50 - 0x53, so that the LPC ports are available.
| > that all legacy IO - joystick, PS/2, parallel, serial, etc is located | > off from that same bridge chip. | > | > Matthieu's comments about using PNP for this seem to make sense. Are | > we missing implementation of an ACPI feature for controlling these | > ports? | | See previous discussion. We have isapnp, biospnp but not great acpi pnp. | None of them help because you need to deal with hotplug.
--
~Randy
Quoted 2 lines · Alan Cox
Nobody else currently needs to attach to it so why make life needlessly complicated.
I just read the relevant parts of the ICH manual. This driver is definitely misnamed. It should be called an "LPC bridge" driver and moved out of the sound directory. The config words that it is using control the joystick and midi, but they also control the floppy, parallel port, serial ports, MSS, SB16, USB, SMbus, IDE, etc.
Shouldn't the BIOS have set these up correctly, does the driver really need to mess with them?
I also don't see how this is related to hotplug. Just because a LPC bridge is plugged in doesn't mean that I should immediatle enable joystick/midi ports, what if I already have those ports on a different device?
Signature · 2 lines
Jon Smirl [email protected]
Quoted 10 lines · On Sun, 05 Sep 2004 21:49:50 +0100 Alan Cox wrote:
| On Sul, 2004-09-05 at 22:24, Jon Smirl wrote: | > I'd don't know enough about the LPC bridge chip to know what the | > correct answer is for this. Right now I tend to think that the PCI | > driver should own the bridge chip. If not the PCI driver then there | > should be an explicit bridge driver. I don' think it is correct that a | > joystick driver is attaching to a bridge chip given the simple fact | | Nobody else currently needs to attach to it so why make life needlessly | complicated.
I just spent a while looking at the code. The joystick driver doesn't need to exist. Instead the snd_intel8x0_probe() routine could have a loop that does pci_get_subsys() over the ID's in snd_intel8x0_joystick_ids[]. When it finds one, use the config space to enable the joystick/midiports. You can locate the ports since pci_get_subsys() returns the pci_dev* for the bridge device. Save the pci_dev* and set the ports back in snd_intel8x0_remove(). Don't forget to pci_put() the bridge device.
This isn't a device driver for the bridge, we just want to locate it and flip some bits. Later on if a driver for the bridge get written it should support an API for setting these bits and the search loop can be removed.
All of these devices are listed as Intel LPC bridges:
2410, 2420, 2440, 244c, 2450, 2480, 2484, 24c0, 24cc, 24d0, 24dc, 25a1, 2640, 2641, 2642
I have a 24D0 which isn't in the driver list, this is probably why MIDI doesn't work on my system.
Signature · 2 lines
Jon Smirl [email protected]