sched.c gratious export removal

PATCH In review Christoph Hellwig 2 participants 2 messages Sep 7, 2004

Share & tools

Christoph Hellwig

author

2004-09-07 16:07 UTC #0 lore raw

PATCH 1/1 sched.c gratious export removal

sched.c exports a few internal helpers although none of them is used in modular code or code that could easily be made modular, nor would we want modules to use them.

kernel/sched.c +0 -7

@@ -1036,8 +1036,6 @@
 	preempt_enable();
 }
 
-EXPORT_SYMBOL_GPL(kick_process);
-
 /*
  * Return a low guess at the load of a migration-source cpu.
  *

@@ -2908,7 +2906,6 @@
 	__wake_up_common(q, mode, nr_exclusive, sync, NULL);
 	spin_unlock_irqrestore(&q->lock, flags);
 }
-EXPORT_SYMBOL_GPL(__wake_up_sync);	/* For internal use only */
 
 void fastcall complete(struct completion *x)
 {

@@ -3142,8 +3139,6 @@
 	return TASK_NICE(p);
 }
 
-EXPORT_SYMBOL(task_nice);
-
 /**
  * idle_cpu - is a given cpu idle currently?
  * @cpu: the processor in question.

@@ -3152,8 +3147,6 @@
 {
 	return cpu_curr(cpu) == cpu_rq(cpu)->idle;
 }
-
-EXPORT_SYMBOL_GPL(idle_cpu);
 
 /**
  * find_process_by_pid - find a process with a matching PID value.

Alan Cox

2004-09-07 18:08 UTC #1 lore raw

kernel/sched.c line 3156

Quoted 13 lines · Christoph Hellwig

sched.c exports a few internal helpers although none of them is used in modular code or code that could easily be made modular, nor would we want modules to use them.
/**
* idle_cpu - is a given cpu idle currently?
* @cpu: the processor in question.
kernel/sched.c +0 -2
@@ -3152,8 +3147,6 @@
 {
 	return cpu_curr(cpu) == cpu_rq(cpu)->idle;
 }
-
-EXPORT_SYMBOL_GPL(idle_cpu);

External power management modules definitely want to know this.