Skip to contentSkip to conversation

unexport files_lock and put_filp

PATCH In review Christoph Hellwig 1 participant 2 messages Sep 7, 2004 VFS

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 unexport files_lock and put_filp

rather lowlevel functions that modules shouldn't mess with and foruntatly currently don't.

fs/file_table.c +1 -5
@@ -24,11 +24,9 @@
 
 EXPORT_SYMBOL(files_stat); /* Needed by unix.o */
 
-/* public *and* exported. Not pretty! */
+/* public. Not pretty! */
 spinlock_t __cacheline_aligned_in_smp files_lock = SPIN_LOCK_UNLOCKED;
 
-EXPORT_SYMBOL(files_lock);
-
 static spinlock_t filp_count_lock = SPIN_LOCK_UNLOCKED;
 
 /* slab constructors and destructors are called from arbitrary
@@ -198,8 +196,6 @@
 		file_free(file);
 	}
 }
-
-EXPORT_SYMBOL(put_filp);
 
 void file_move(struct file *file, struct list_head *list)
 {
#1 lore raw
Quoted 1 line · Christoph Hellwig

rather lowlevel functions that modules shouldn't mess with and

Umm, file_list_lock is of course not a function but a global lock variable - even worse.