Skip to contentSkip to conversation

Current BK breakage

PATCH Anton Blanchard 2 participants 2 messages Sep 9, 2004 VFS

lore
Share & tools
lore
#0 lore raw

Hi,

Looks like a bug in the cleanup patch :)

Anton

===== buffer.c 1.256 vs edited =====

buffer.c renamed from fs/buffer.c +1 -1
@@ -895,7 +895,7 @@
 		spin_lock(&buffer_mapping->private_lock);
 		list_move_tail(&bh->b_assoc_buffers,
 				&mapping->private_list);
-		spin_lock(&buffer_mapping->private_lock);
+		spin_unlock(&buffer_mapping->private_lock);
 }
 
 }
#1 lore raw
Quoted 2 lines · Anton Blanchard

Looks like a bug in the cleanup patch :)

oop. Shows how many people are testing ext2. Let's fix up that whitespace also.

fs/buffer.c renamed from fs/buffer.c~a +2 -3
@@ -895,9 +895,8 @@ void mark_buffer_dirty_inode(struct buff
 		spin_lock(&buffer_mapping->private_lock);
 		list_move_tail(&bh->b_assoc_buffers,
 				&mapping->private_list);
-		spin_lock(&buffer_mapping->private_lock);
-}
-
+		spin_unlock(&buffer_mapping->private_lock);
+	}
 }
 EXPORT_SYMBOL(mark_buffer_dirty_inode);
 

_