atm/he: replace schedule_timeout()
Subsystems (2)
PATCH 3/5 atm/he: replace schedule_timeout()
Any comments would be appreciated. This is a re-push of a patch I sent 19 July but the changes haven't appared in either 2.6.9-rc1-mm5 or 2.6.9-rc2.
Description: msleep() is used instead of schedule_timeout() to guarantee the task delays as expected. Also, an extraneous set_current_state() is removed, as the task is guaranteed to be in TASK_RUNNING upon returning from schedule_timeout().
Signed-off-by Nishanth Aravamudan <[email protected]>
drivers/atm/he.c +1 -3
@@ -2569,7 +2569,6 @@ he_close(struct atm_vcc *vcc) timeout =schedule_timeout (30 *HZ );remove_wait_queue (&he_vcc->rx_waitq, &wait); -set_current_state (TASK_RUNNING );if (timeout ==0 )hprintk ("close rx timeout cid 0x%x\n" , cid);
@@ -2595,8 +2594,7 @@ he_close(struct atm_vcc *vcc)while (((tx_inuse =atomic_read (&vcc->sk->sk_wmem_alloc)) >0 ) && (retry <MAX_RETRY )) { -set_current_state (TASK_UNINTERRUPTIBLE ); - (void )schedule_timeout (sleep); +msleep (jiffies_to_msecs (sleep));if (sleep <HZ ) sleep = sleep *2 ;
_______________________________________________
Kernel-janitors mailing list
[email protected]
http://lists.osdl.org/mailman/listinfo/kernel-janitors