block/pg: replace pg_sleep() with
Subsystems (2)
PATCH 4/8 block/pg: replace pg_sleep() with
Any comments would be appreciated. This is a re-push of a patch I submitted 20 July which hasn't been merged as of 2.6.9-rc1-mm5/2.6.9-rc2.
Description: msleep_interruptible() is used instead of pg_sleep() to guarantee the task delays as expected. The defintion of pg_sleep() is also modified to use set_current_state() instead of direct assignment.
Signed-off-by Nishanth Aravamudan <[email protected]>
drivers/block/paride/pg.c +2 -2
@@ -295,7 +295,7 @@ static inline u8 DRIVE(struct pg *dev)static void pg_sleep (int cs) { - current->state =TASK_INTERRUPTIBLE ; +set_current_state (TASK_INTERRUPTIBLE );schedule_timeout (cs); }
@@ -409,7 +409,7 @@ static int pg_reset(struct pg *dev)write_reg (dev,6 ,DRIVE (dev));write_reg (dev,7 ,8 ); -pg_sleep (20 *HZ /1000 ); +msleep_interruptible (20 ); k =0 ;while ((k++ <PG_RESET_TMO ) && (status_reg (dev) &STAT_BUSY ))
_______________________________________________
Kernel-janitors mailing list
[email protected]
http://lists.osdl.org/mailman/listinfo/kernel-janitors