char/ftape-io: replace
PATCH 8/33 char/ftape-io: replace
Any comments would be appreciated.
Description: Use msleep_interruptible() instead of schedule_timeout() to guarantee the task delays as expected. In this case, this allowed for the removal of the entire do-while.
drivers/char/ftape/lowlevel/ftape-io.c +6 -13
@@ -96,19 +96,12 @@ void ftape_sleep(unsigned int time) timeout = ticks;save_flags (flags);sti (); -set_current_state (TASK_INTERRUPTIBLE ); -do { -/* Mmm. Isn't current->blocked == 0xffffffff ? -*/ -if (signal_pending (current)) { -TRACE (ft_t_err, -"awoken by non-blocked signal :-(" ); -break ;/* exit on signal */ - } -while (current->state !=TASK_RUNNING ) { - timeout =schedule_timeout (timeout); - } - }while (timeout); +msleep_interruptible (jiffies_to_msecs (timeout)); +/* Mmm. Isn't current->blocked == 0xffffffff ? +*/ +if (signal_pending (current)) { +TRACE (ft_t_err,"awoken by non-blocked signal :-(" ); + }restore_flags (flags); }TRACE_EXIT ;
_______________________________________________
Kernel-janitors mailing list
[email protected]
http://lists.osdl.org/mailman/listinfo/kernel-janitors
Quoted 26 lines · Nishanth Aravamudan
Any comments would be appreciated.
Description: Use
msleep_interruptible()instead ofschedule_timeout()to guarantee the task delays as expected. In this case, this allowed for the removal of the entire do-while.Signed-off-by Nishanth Aravamudan <[email protected]>drivers/char/ftape/lowlevel/ftape-io.c +0
-12@@ -96,19 +96,12 @@ void ftape_sleep(unsigned int time) timeout = ticks;save_flags (flags);sti (); -set_current_state (TASK_INTERRUPTIBLE ); - do { - /* Mmm. Isn't current->blocked == 0xffffffff ? - */ - if (signal_pending(current)) { - TRACE(ft_t_err, - "awoken by non-blocked signal :-("); - break; /* exit on signal */ - } - while (current->state != TASK_RUNNING) { - timeout = schedule_timeout(timeout); - }
drivers/char/ftape/lowlevel/ftape-io.c void ftape_sleep(unsigned int time) · line 107
Quoted 10 lines
drivers/char/ftape/lowlevel/ftape-io.c +6
-1- }while (timeout); +msleep_interruptible (jiffies_to_msecs (timeout)); +/* Mmm. Isn't current->blocked == 0xffffffff ? +*/ +if (signal_pending (current)) { +TRACE (ft_t_err,"awoken by non-blocked signal :-(" ); + }restore_flags (flags); }TRACE_EXIT ;
this one missed an include too. fixed for next kjt. a++ maks
_______________________________________________
Kernel-janitors mailing list
[email protected]
http://lists.osdl.org/mailman/listinfo/kernel-janitors