Skip to contentSkip to conversation

make make install install modules too

PATCH In review Matthew Wilcox 6 participants 9 messages Sep 17, 2004 – Sep 27, 2004

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 make make install install modules too

I keep forgetting to run 'make modules_install' after make install. Since make now compiles modules too and there's no separate make modules step, it seems to make sense that make install should also install modules.

Index: linux-2.6/arch/i386/Makefile
===================================================================
RCS file: /var/cvs/linux-2.6/arch/i386/Makefile,v
retrieving revision 1.11

arch/i386/Makefile +4 -2
diff -u -p -r1.11 Makefile
@@ -117,7 +117,7 @@ AFLAGS += $(mflags-y)
 boot := arch/i386/boot
 
 .PHONY: zImage bzImage compressed zlilo bzlilo \
-	zdisk bzdisk fdimage fdimage144 fdimage288 install
+	zdisk bzdisk fdimage fdimage144 fdimage288 install kernel_install
 
 all: bzImage
 
@@ -136,8 +136,10 @@ zlilo bzlilo: vmlinux
 zdisk bzdisk: vmlinux
 	$(Q)$(MAKE) $(build)=$(boot) BOOTIMAGE=$(KBUILD_IMAGE) zdisk
 
-install fdimage fdimage144 fdimage288: vmlinux
+kernel_install fdimage fdimage144 fdimage288: vmlinux
 	$(Q)$(MAKE) $(build)=$(boot) BOOTIMAGE=$(KBUILD_IMAGE) $@
+
+install: kernel_install modules_install
 
 prepare: include/asm-$(ARCH)/asm_offsets.h
 CLEAN_FILES += include/asm-$(ARCH)/asm_offsets.h

Index: linux-2.6/arch/i386/boot/Makefile
===================================================================
RCS file: /var/cvs/linux-2.6/arch/i386/boot/Makefile,v retrieving revision 1.5

arch/i386/boot/Makefile +1 -1
diff -u -p -r1.5 Makefile
@@ -100,5 +100,5 @@ zlilo: $(BOOTIMAGE)
 	cp System.map $(INSTALL_PATH)/
 	if [ -x /sbin/lilo ]; then /sbin/lilo; else /etc/lilo/install; fi
 
-install: $(BOOTIMAGE)
+kernel_install: $(BOOTIMAGE)
 	sh $(srctree)/$(src)/install.sh $(KERNELRELEASE) $< System.map "$(INSTALL_PATH)"
Signature · 6 lines
"Next the statesmen will invent cheap lies, putting the blame upon 
the nation that is attacked, and every man will be glad of those
conscience-soothing falsities, and will diligently study them, and refuse
to examine any refutations of them; and thus he will by and by convince 
himself that the war is just, and will thank God for the better sleep 
he enjoys after this process of grotesque self-deception." -- Mark Twain
#1 lore raw
Quoted 4 lines · Matthew Wilcox

I keep forgetting to run 'make modules_install' after make install. Since make now compiles modules too and there's no separate make modules step, it seems to make sense that make install should also install modules.

This is not a good patch IMO. Many of us do things with scripts to drive the compile process, either in the name of repeatability or
consistency. These scripts may step out of the src tree and go make
something else (lm_sensors comes to mind when it wasn't part of the kernel) whose output goes into the /lib/modules/version/ directory so that by the time the make modules_install runs, everything is already in place for the automatic depmod the modules_install does. We *could* work around it by re-adding the depmod lines to our scripts, but it seems that might be called a kludge too.

Quoted 43 lines

Index: linux-2.6/arch/i386/Makefile
===================================================================
RCS file: /var/cvs/linux-2.6/arch/i386/Makefile,v
retrieving revision 1.11
diff -u -p -r1.11 Makefile

arch/i386/Makefile 17 Sep 2004 16:57:03 -0000 renamed from arch/i386/Makefile 13 Sep 2004 15:22:09 -0000 1.11 +0 -0
@@ -117,7 +117,7 @@ AFLAGS += $(mflags-y)

boot := arch/i386/boot

.PHONY: zImage bzImage compressed zlilo bzlilo \
- zdisk bzdisk fdimage fdimage144 fdimage288 install
+ zdisk bzdisk fdimage fdimage144 fdimage288 install kernel_install

all: bzImage

arch/i386/Makefile 17 Sep 2004 16:57:03 -0000 renamed from arch/i386/Makefile 13 Sep 2004 15:22:09 -0000 1.11 +0 -0
@@ -136,8 +136,10 @@ zlilo bzlilo: vmlinux

zdisk bzdisk: vmlinux

	$(Q)$(MAKE) $(build)=$(boot) BOOTIMAGE=$(KBUILD_IMAGE) zdisk
arch/i386/Makefile 17 Sep 2004 16:57:03 -0000 renamed from arch/i386/Makefile 13 Sep 2004 15:22:09 -0000 1.11 +1 -1
-install fdimage fdimage144 fdimage288: vmlinux
+kernel_install fdimage fdimage144 fdimage288: vmlinux
	$(Q)$(MAKE) $(build)=$(boot) BOOTIMAGE=$(KBUILD_IMAGE) $@
arch/i386/Makefile 17 Sep 2004 16:57:03 -0000 renamed from arch/i386/Makefile 13 Sep 2004 15:22:09 -0000 1.11 +2 -0
+
+install: kernel_install modules_install

prepare: include/asm-$(ARCH)/asm_offsets.h CLEAN_FILES += include/asm-$(ARCH)/asm_offsets.h
Index: linux-2.6/arch/i386/boot/Makefile
===================================================================
RCS file: /var/cvs/linux-2.6/arch/i386/boot/Makefile,v retrieving revision 1.5
diff -u -p -r1.5 Makefile

arch/i386/boot/Makefile +1 -1
@@ -100,5 +100,5 @@ zlilo: $(BOOTIMAGE)
 	cp System.map $(INSTALL_PATH)/
 	if [ -x /sbin/lilo ]; then /sbin/lilo; else /etc/lilo/install; fi
 
-install: $(BOOTIMAGE)
+kernel_install: $(BOOTIMAGE)
 	sh $(srctree)/$(src)/install.sh $(KERNELRELEASE) $< System.map

"$(INSTALL_PATH)"

Signature · 8 lines
Cheers, Gene
"There are four boxes to be used in defense of liberty:
 soap, ballot, jury, and ammo. Please use in that order."
-Ed Howdershelt (Author)
99.26% setiathome rank, not too shabby for a WV hillbilly
Yahoo.com attorneys please note, additions to this message
by Gene Heskett are:
Copyright 2004 by Maurice Eugene Heskett, all rights reserved.
#2 lore raw
Quoted 9 lines · Gene Heskett

This is not a good patch IMO. Many of us do things with scripts to drive the compile process, either in the name of repeatability or
consistency. These scripts may step out of the src tree and go make
something else (lm_sensors comes to mind when it wasn't part of the kernel) whose output goes into the /lib/modules/version/ directory so that by the time the make modules_install runs, everything is already in place for the automatic depmod the modules_install does. We *could* work around it by re-adding the depmod lines to our scripts, but it seems that might be called a kludge too.

Documentation/kbuild/modules.txt answers how to do this "right". In any case, there's nothing to stop you changing your scripts from "make install && do_my_special_thing && make modules_install" to
"make kernel_install && do_my_special_thing && make modules_install"

Signature · 6 lines
"Next the statesmen will invent cheap lies, putting the blame upon 
the nation that is attacked, and every man will be glad of those
conscience-soothing falsities, and will diligently study them, and refuse
to examine any refutations of them; and thus he will by and by convince 
himself that the war is just, and will thank God for the better sleep 
he enjoys after this process of grotesque self-deception." -- Mark Twain
#3 lore raw
Quoted 12 lines · Matthew Wilcox
Quoted 10 lines · Gene Heskett

This is not a good patch IMO. Many of us do things with scripts to drive the compile process, either in the name of repeatability
or consistency. These scripts may step out of the src tree and
go make something else (lm_sensors comes to mind when it wasn't part of the kernel) whose output goes into the /lib/modules/version/ directory so that by the time the make modules_install runs, everything is already in place for the automatic depmod the modules_install does. We *could* work around it by re-adding the depmod lines to our scripts, but it seems that might be called a kludge too.

Quoted 4 lines

Documentation/kbuild/modules.txt answers how to do this "right". In any case, there's nothing to stop you changing your scripts from "make install && do_my_special_thing && make modules_install" to "make kernel_install && do_my_special_thing && make modules_install"

Entirely true. But in the interest of doing it consistently AND my way, I have never used the make kernel install feature, doing my own copying, renameing etc. And my own grub.conf editing too.

In my case (and I'm an old (70ish) fart getting stuck in my ways) I simply haven't needed to fix what isn't broken until such time as it
actually does break. It isn't broken, yet.. :-)

Signature · 8 lines
Cheers, Gene
"There are four boxes to be used in defense of liberty:
 soap, ballot, jury, and ammo. Please use in that order."
-Ed Howdershelt (Author)
99.26% setiathome rank, not too shabby for a WV hillbilly
Yahoo.com attorneys please note, additions to this message
by Gene Heskett are:
Copyright 2004 by Maurice Eugene Heskett, all rights reserved.
#4 lore raw
In reply to Matthew Wilcox
Quoted 4 lines · Matthew Wilcox

I keep forgetting to run 'make modules_install' after make install. Since make now compiles modules too and there's no separate make modules step, it seems to make sense that make install should also install modules.

No, we do not want to change such basic behaviour. So many poeple are used to current scheme with:
make modules_install && make install

that it would't be worth breaking their ways of working.

Sam

#5 lore raw
Quoted 11 lines · Sam Ravnborg
Quoted 4 lines · Matthew Wilcox

I keep forgetting to run 'make modules_install' after make install. Since make now compiles modules too and there's no separate make modules step, it seems to make sense that make install should also install modules.

No, we do not want to change such basic behaviour. So many poeple are used to current scheme with:
make modules_install && make install

that it would't be worth breaking their ways of working.

Ehm, this wouldn't _break_ them. They'd just end up installing modules twice.

Signature · 6 lines
"Next the statesmen will invent cheap lies, putting the blame upon 
the nation that is attacked, and every man will be glad of those
conscience-soothing falsities, and will diligently study them, and refuse
to examine any refutations of them; and thus he will by and by convince 
himself that the war is just, and will thank God for the better sleep 
he enjoys after this process of grotesque self-deception." -- Mark Twain
#6 lore raw
Quoted 13 lines · Matthew Wilcox

Date: Mon, 27 Sep 2004 12:37:27 +0100
From: Matthew Wilcox <[email protected]>
To: Matthew Wilcox <[email protected]>, Linus Torvalds <[email protected]>,
Andrew Morton <[email protected]>, [email protected]
Subject: Re: [PATCH] make make install install modules too

Quoted 6 lines · Sam Ravnborg
Quoted 4 lines · Matthew Wilcox

I keep forgetting to run 'make modules_install' after make install. Since make now compiles modules too and there's no separate make modules step, it seems to make sense that make install should also install modules.

Quoted 9 lines
Quoted 5 lines

No, we do not want to change such basic behaviour. So many poeple are used to current scheme with:
make modules_install && make install

that it would't be worth breaking their ways of working.

Ehm, this wouldn't _break_ them. They'd just end up installing modules twice.

And how about people who, for some reason, don't want the modules installed?
Sure, you can just copy the files you want by hand, which is what I do personally, but I find it nice that installing the kernel image and modules are two sepperate steps. If a user wants both done automagically, then that user could just create a 2 line shell script.

Or how about leaving "make install" and "make modules_install" as is and add a new target, say, "make install_all" or similar?

--
Jesper Juhl <[email protected]>

#7 lore raw
Quoted 7 lines · Jesper Juhl
Quoted 6 lines
Quoted 6 lines · Matthew Wilcox
Quoted 4 lines

I keep forgetting to run 'make modules_install' after make install. Since make now compiles modules too and there's no separate make modules step, it seems to make sense that make install should also install modules.

Quoted 6 lines

And how about people who, for some reason, don't want the modules installed?
Sure, you can just copy the files you want by hand, which is what I do personally, but I find it nice that installing the kernel image and modules are two sepperate steps. If a user wants both done automagically, then that user could just create a 2 line shell script.

indeed, this should do what you want

$ cat ~/bin/installkernel

#!/bin/sh

cp .config /boot/config-$1
cp $3 /boot/System.map-$1
cp $2 /boot/vmlinuz-$1
make modules_install

-- Cal

#8 lore raw
In reply to Matthew Wilcox
Quoted 8 lines
Quoted 5 lines

No, we do not want to change such basic behaviour. So many poeple are used to current scheme with:
make modules_install && make install

that it would't be worth breaking their ways of working.

Ehm, this wouldn't _break_ them. They'd just end up installing modules twice.

Broken in the sense that it does more than expected.

Sam