Skip to contentSkip to conversation

rme32 segfault fix

PATCH Applied Martin Langer 2 participants 2 messages Sep 19, 2004 – Sep 20, 2004

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 rme32 segfault fix

Hi,

looks like rme32 in halfduplex mode is broken for playback (since v1.0.6). You will get a segfault without this patch :(

Changes:
- disables buffer prefill in halfduplex mode, which fixes segmentation fault of rme32 for playback in halfduplex mode

Signed-Off by Martin Langer <[email protected]>

martin

pci/rme32.c renamed from pci/rme32.c.ORIGINAL +1 -1
@@ -1123,7 +1123,7 @@
 	}
 	
 	/* prefill playback buffer */
-	if (cmd == SNDRV_PCM_TRIGGER_START) {
+	if ((cmd == SNDRV_PCM_TRIGGER_START) && (rme32->fullduplex_mode)) {
 		snd_pcm_group_for_each(pos, substream) {
 			s = snd_pcm_group_substream_entry(pos);
 			if (s == rme32->playback_substream) {
Applied
#1 lore raw

At Sun, 19 Sep 2004 22:10:18 +0200,

Quoted 5 lines · Martin Langer

Hi,

looks like rme32 in halfduplex mode is broken for playback (since v1.0.6). You will get a segfault without this patch :(

Applied. Thanks!

Takashi

-------------------------------------------------------
This SF.Net email is sponsored by: YOU BE THE JUDGE. Be one of 170 Project Admins to receive an Apple iPod Mini FREE for your judgement on who ports your project to Linux PPC the best. Sponsored by IBM.
Deadline: Sept. 24. Go here: http://sf.net/ppc_contest.php