media/bw-qcam: replace
Subsystems (2)
PATCH 2/17 media/bw-qcam: replace
Any comments would be appreciated.
Description: Use msleep_interruptible() instead of schedule_timeout() to guarantee the task delays as expected.
Signed-off-by Nishanth Aravamudan <[email protected]>
drivers/media/video/bw-qcam.c +4 -8
@@ -249,8 +249,7 @@ static int qc_waithand(struct qcam_devicif (runs++>maxpoll) { - current->state=TASK_INTERRUPTIBLE ; -schedule_timeout (HZ /200 ); +msleep_interruptible (5 ); }if (runs>(maxpoll+1000 ))/* 5 seconds */ return -1 ;
@@ -269,8 +268,7 @@ static int qc_waithand(struct qcam_devicif (runs++>maxpoll) { - current->state=TASK_INTERRUPTIBLE ; -schedule_timeout (HZ /200 ); +msleep_interruptible (5 ); }if (runs++>(maxpoll+1000 ))/* 5 seconds */ return -1 ;
@@ -302,8 +300,7 @@ static unsigned int qc_waithand2(structif (runs++>maxpoll) { - current->state=TASK_INTERRUPTIBLE ; -schedule_timeout (HZ /200 ); +msleep_interruptible (5 ); }if (runs++>(maxpoll+1000 ))/* 5 seconds */ return 0 ;
@@ -669,8 +666,7 @@ long qc_capture(struct qcam_device * q,time will be 240 / 200 = 1.2 seconds. The compile-time default is to yield every 4 lines. */ if (i >= yield) { - current->state=TASK_INTERRUPTIBLE ; -schedule_timeout (HZ /200 ); +msleep_interruptible (5 ); yield = i + yieldlines; } }
_______________________________________________
Kernel-janitors mailing list
[email protected]
http://lists.osdl.org/mailman/listinfo/kernel-janitors