media/cpia: replace
Subsystems (2)
PATCH 4/17 media/cpia: replace
Any comments would be appreciated.
Description: Use msleep_interruptible() instead of schedule_timeout() to guarantee the task delays as expected.
Signed-off-by Nishanth Aravamudan <[email protected]>
drivers/media/video/cpia.c +6 -11
@@ -37,6 +37,7 @@#include <linux/proc_fs.h> #include <linux/ctype.h> #include <linux/pagemap.h> +#include <linux/delay.h> #include <asm/io.h> #include <asm/semaphore.h>
@@ -2886,9 +2887,7 @@ static int fetch_frame(void *data)cond_resched ();/* sleep for 10 ms, hopefully ;) */ - current->state =TASK_INTERRUPTIBLE ; - -schedule_timeout (10 *HZ /1000 ); +msleep_interruptible (10 );if (signal_pending (current))return -EINTR ;
@@ -2951,8 +2950,7 @@ static int fetch_frame(void *data) CPIA_GRAB_SINGLE, 0, 0, 0);/* FIXME: Trial & error - need up to 70ms for the grab mode change to complete ? */ - current->state =TASK_INTERRUPTIBLE ; -schedule_timeout (70 *HZ /1000 ); +msleep_interruptible (70 );if (signal_pending (current))return -EINTR ; }
@@ -3003,8 +3001,7 @@ static int goto_high_power(struct cam_da {if (do_command (cam, CPIA_COMMAND_GotoHiPower,0 ,0 ,0 ,0 ))return -EIO ; - current->state =TASK_INTERRUPTIBLE ; -schedule_timeout (40 *HZ /1000 );/* windows driver does it too */ +msleep_interruptible (40 );/* windows driver does it too */ if (signal_pending (current))return -EINTR ;if (do_command (cam, CPIA_COMMAND_GetCameraStatus,0 ,0 ,0 ,0 ))
@@ -3074,10 +3071,8 @@ static int set_camera_state(struct cam_d/* Wait 6 frames for the sensor to get all settings and AEC/ACB to settle */ - current->state =TASK_INTERRUPTIBLE ; -schedule_timeout ((6 *(cam->params.sensorFps.baserate ?33 :40 ) * - (1 << cam->params.sensorFps.divisor) +10 ) * -HZ /1000 ); +msleep_interruptible (6 *(cam->params.sensorFps.baserate ?33 :40 ) * + (1 << cam->params.sensorFps.divisor) +10 );if (signal_pending (current))return -EINTR ;
_______________________________________________
Kernel-janitors mailing list
[email protected]
http://lists.osdl.org/mailman/listinfo/kernel-janitors
PATCH 4/17 media/cx88-tvaudio:
Any comments would be appreciated.
Description: Use msleep_interruptible() instead of schedule_timeout() to guarantee the task delays as expected.
Signed-off-by Nishanth Aravamudan <[email protected]>
drivers/media/video/cx88/cx88-tvaudio.c +2 -2
@@ -49,6 +49,7 @@#include <linux/vmalloc.h> #include <linux/init.h> #include <linux/smp_lock.h> +#include <linux/delay.h> #include "cx88.h"
@@ -785,8 +786,7 @@ int cx88_audio_thread(void *data)dprintk ("cx88: tvaudio thread started\n" );for (;;) { -set_current_state (TASK_INTERRUPTIBLE ); -schedule_timeout (HZ *3 ); +msleep_interruptible (3000 );if (signal_pending (current))break ;if (dev->shutdown)
_______________________________________________
Kernel-janitors mailing list
[email protected]
http://lists.osdl.org/mailman/listinfo/kernel-janitors