Skip to contentSkip to conversation

net/e1000_ethtool: replace

PATCH New Nishanth Aravamudan 1 participant 1 message Sep 22, 2004

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 9/38 net/e1000_ethtool: replace

Any comments would be appreciated.

Description: Use msleep_interruptible() instead of schedule_timeout() to guarantee the task delays as expected.

drivers/net/e1000/e1000_ethtool.c +1 -3
@@ -1549,9 +1549,7 @@ e1000_phys_id(struct net_device *netdev,
 	e1000_setup_led(&adapter->hw);
 	mod_timer(&adapter->blink_timer, jiffies);
 
-	set_current_state(TASK_INTERRUPTIBLE);
-
-	schedule_timeout(data * HZ);
+	msleep_interruptible(data * 1000);
 	del_timer_sync(&adapter->blink_timer);
 	e1000_led_off(&adapter->hw);
 	clear_bit(E1000_LED_ON, &adapter->led_status);

_______________________________________________
Kernel-janitors mailing list
[email protected]
http://lists.osdl.org/mailman/listinfo/kernel-janitors