net/ixgb_osdep: replace
Subsystems (2)
PATCH 20/38 net/ixgb_osdep: replace
Any comments would be appreciated.
Description: Use msleep() instead of schedule_timeout()
to guarantee the task delays as expected. I was told earlier that the in_interrupt() check is not necessary. It would be nice to get some verification of this (i.e. the driver functions the same without it).
Signed-off-by Nishanth Aravamudan <[email protected]>
drivers/net/ixgb/ixgb_osdep.h +1 -7
@@ -41,13 +41,7 @@#include <linux/sched.h> #ifndef msec_delay -#define msec_delay (x) do { if(in_interrupt()) { \ -/* Don't mdelay in interrupt context! */ \ -BUG (); \ - } else { \ -set_current_state (TASK_UNINTERRUPTIBLE ); \ - schedule_timeout((x * HZ)/1000 + 2); \ - } } while(0) +#define msec_delay (x) msleep(x)#endif #define PCI_COMMAND_REGISTER PCI_COMMAND
_______________________________________________
Kernel-janitors mailing list
[email protected]
http://lists.osdl.org/mailman/listinfo/kernel-janitors