Skip to contentSkip to conversation

PATCH: TTY ldisc and termios locking work

DISCUSSION Linus Torvalds 2 participants 2 messages Sep 27, 2004 1 message not in the archive

lore
Share & tools
lore
#1 lore raw
In reply to a message not in the archive

Alan,
this seems to be corrupted. A quick read-through found this in
generic_serial.c:

+ ld = tty_ldisc_ref(tty);
+ if (ld != NULL) {
+ ld->flush_buffer)
+ ld->flush_buffer(tty);
+ tty_ldisc_deref(ld);
+ }

I can see the missing "if (" in my mind, but I'm wondering what else I might have missed. Ie can we have this patch be tested a bit more first?

Linus

#2 lore raw
Quoted 9 lines · Linus Torvalds
(quoted diff) +6 -0
+       ld = tty_ldisc_ref(tty);
+       if (ld != NULL) {
+               ld->flush_buffer)
+                       ld->flush_buffer(tty);
+               tty_ldisc_deref(ld);
+       }

I can see the missing "if (" in my mind, but I'm wondering what else I might have missed. Ie can we have this patch be tested a bit more first?

Its been running for several days. generic_serial got missed because its BROKEN_ON_SMP for all users and so never got built. Fixed in my tree now.

Alan