Skip to contentSkip to conversation

pcmcia/ds: replace

PATCH New Nishanth Aravamudan 1 participant 1 message Sep 27, 2004

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 2/5 pcmcia/ds: replace

Any comments would be appreciated.

Description: Use msleep_interruptible() instead of schedule_timeout() to guarantee the task delays as expected.

drivers/pcmcia/ds.c +2 -2
@@ -51,6 +51,7 @@
 #include <linux/pci.h>
 #include <linux/list.h>
 #include <linux/workqueue.h>
+#include <linux/delay.h>
 
 #include <asm/atomic.h>
 
@@ -1080,8 +1081,7 @@ static int __devinit pcmcia_bus_add_sock
 	 * Ugly. But we want to wait for the socket threads to have started up.
 	 * We really should let the drivers themselves drive some of this..
 	 */
-	current->state = TASK_INTERRUPTIBLE;
-	schedule_timeout(HZ/4);
+	msleep_interruptible(250);
 
 	init_waitqueue_head(&s->queue);
 	init_waitqueue_head(&s->request);

_______________________________________________
Kernel-janitors mailing list
[email protected]
http://lists.osdl.org/mailman/listinfo/kernel-janitors