serial/68360serial: replace
PATCH 2/6 serial/68360serial: replace
Any comments would be appreciated.
Description: Use msleep_interruptible() instead of schedule_timeout() to guarantee the task delays as expected. Use set_current_state() instead of direct assignment of current->state.
drivers/serial/68360serial.c +3 -5
@@ -1411,7 +1411,7 @@ static void end_break(ser_info_t *info)*/ static void send_break (ser_info_t *info,int duration) { - current->state =TASK_INTERRUPTIBLE ; +set_current_state (TASK_INTERRUPTIBLE );#ifdef SERIAL_DEBUG_SEND_BREAK printk ("rs_send_break(%d) jiff=%lu..." , duration, jiffies);#endif
@@ -1723,8 +1723,7 @@ static void rs_360_close(struct tty_stru info->tty =0 ;if (info->blocked_open) {if (info->close_delay) { - current->state =TASK_INTERRUPTIBLE ; -schedule_timeout (info->close_delay); +msleep_interruptible (jiffies_to_msecs (info->close_delay)); }wake_up_interruptible (&info->open_wait); }
@@ -1777,9 +1776,8 @@ static void rs_360_wait_until_sent(struc#ifdef SERIAL_DEBUG_RS_WAIT_UNTIL_SENT printk ("lsr = %d (jiff=%lu)..." , lsr, jiffies);#endif - current->state =TASK_INTERRUPTIBLE ;/* current->counter = 0; make us low-priority */ -schedule_timeout (char_time); +msleep_interruptible (jiffies_to_msecs (char_time));if (signal_pending (current))break ;if (timeout && ((orig_jiffies + timeout) < jiffies))
_______________________________________________
Kernel-janitors mailing list
[email protected]
http://lists.osdl.org/mailman/listinfo/kernel-janitors