serial/mcfserial: replace
PATCH 4/6 serial/mcfserial: replace
Any comments would be appreciated.
Description: Use msleep_interruptible() instead of schedule_timeout() to guarantee the task delays as expected. Use set_current_state() instead of direct assignment of current->state.
drivers/serial/mcfserial.c +4 -5
@@ -34,6 +34,7 @@#include <linux/serialP.h> #include <linux/console.h> #include <linux/init.h> +#include <linux/delay.h> #include <asm/io.h> #include <asm/irq.h>
@@ -997,7 +998,7 @@ static void send_break( struct mcf_seriaif (!info->addr)return ; - current->state =TASK_INTERRUPTIBLE ; +set_current_state (TASK_INTERRUPTIBLE ); uartp = info->addr;local_irq_save (flags);
@@ -1247,8 +1248,7 @@ static void mcfrs_close(struct tty_struc }if (info->blocked_open) {if (info->close_delay) { - current->state =TASK_INTERRUPTIBLE ; -schedule_timeout (info->close_delay); +msleep_interruptible (jiffies_to_msecs (info->close_delay)); }wake_up_interruptible (&info->open_wait); }
@@ -1313,8 +1313,7 @@ mcfrs_wait_until_sent(struct tty_struct fifo_cnt++;if (fifo_cnt ==0 )break ; -set_current_state (TASK_INTERRUPTIBLE ); -schedule_timeout (char_time); +msleep_interruptible (jiffies_to_msecs (char_time));if (signal_pending (current))break ;if (timeout &&time_after (jiffies, orig_jiffies + timeout))
_______________________________________________
Kernel-janitors mailing list
[email protected]
http://lists.osdl.org/mailman/listinfo/kernel-janitors