gdth update
A message that is not in the archive (sent off-list or not yet received): [email protected]
Quoted 3 lines · Linux Kernel Mailing List
* IO-mapping with
virt_to_bus(),gdth_readb(),gdth_writeb(), ...
- *register_reboot_notifier()to get a notify on shutdown used
+ *register_reboot_notifier()to get a notify on shutown used
why this change ?
Review
Quoted 6 lines
(quoted diff) +3
-1+#if LINUX_VERSION_CODE >= KERNEL_VERSION(2,6,0) +static irqreturn_t gdth_interrupt(int irq, void *dev_id, struct pt_regs *regs); #else -static void gdth_interrupt(int irq,struct pt_regs *regs); +static void gdth_interrupt(int irq, void *dev_id, struct pt_regs *regs); #endif
this really is the wrong way to do such irq prototype compatibility in drivers. *really*
Review
Quoted 10 lines
(quoted diff) +10
-0+static struct file_operations gdth_fops = { +#if LINUX_VERSION_CODE >= KERNEL_VERSION(2,6,0) + .ioctl = gdth_ioctl, + .open = gdth_open, + .release = gdth_close, +#else + ioctl:gdth_ioctl, + open:gdth_open, + release:gdth_close, +#endif
C99 initializers work in all kernel versions since it's a property of the C compiler not of the kernel. I wonder why you are putting this ifdef here....
the rest of your ifdefs are generally quite fishy too unfortionately...