Skip to contentSkip to conversation

sbus/aurora: replace schedule_timeout() with

Kernel-janitors Domen Puncer 2 participants 2 messages Sep 29, 2004

Subsystems (2)
Kernel janitors SPARC + UltraSPARC (sparc/sparc64)
lore
Share & tools
lore
#1 lore raw
Quoted 6 lines · Domen Puncer

Review

Quoted 3 lines · Nishanth Aravamudan
(quoted diff) +1 -2
-			current->state = TASK_INTERRUPTIBLE;
-			schedule_timeout(port->close_delay);
+			msleep_interruptible(port->close_delay);

I think you forgot jiffies_to_msecs here.

Please find the corrected patch below.
Thanks for catching this, Domen.

drivers/sbus/char/aurora.c +2 -4
@@ -1519,8 +1519,7 @@ static void aurora_close(struct tty_stru
 		 */
 		timeout = jiffies+HZ;
 		while(port->SRER & SRER_TXEMPTY)  {
-			current->state = TASK_INTERRUPTIBLE;
-			schedule_timeout(port->timeout);
+			msleep_interruptible(jiffies_to_msecs(port->timeout));
 			if (time_after(jiffies, timeout))
 				break;
 		}

@@ -1538,8 +1537,7 @@ static void aurora_close(struct tty_stru
 	port->tty = 0;
 	if (port->blocked_open) {
 		if (port->close_delay) {
-			current->state = TASK_INTERRUPTIBLE;
-			schedule_timeout(port->close_delay);
+			msleep_interruptible(jiffies_to_msecs(port->close_delay));
 		}
 		wake_up_interruptible(&port->open_wait);
 	}

_______________________________________________
Kernel-janitors mailing list
[email protected]
http://lists.osdl.org/mailman/listinfo/kernel-janitors