Skip to contentSkip to conversation

Per-priority statistics for CFQ w/iopriorities 2.6.8.1

PATCH Jens Axboe 2 participants 5 messages Sep 30, 2004

lore
Share & tools
lore

Jens Axboe

author
#0 lore raw

Hi,

Missed this patch the first time over (thank you lwn :-) - why are you using atomic counters? In all the paths you set them, you already have the queue lock.

Signature · 1 line
Jens Axboe
#1 lore raw
Quoted 6 lines · Jens Axboe

Hi,

Missed this patch the first time over (thank you lwn :-) - why are you using atomic counters? In all the paths you set them, you already have the queue lock.

Thats right, there's no need for them. I used these instinctively....
Will fix in next version, unless (hint, hint) you're taking a look at adding priorities back to mainline's CFQ.

-- Shailabh

author
#2 lore raw
Quoted 11 lines · Shailabh Nagar
Quoted 6 lines · Jens Axboe

Hi,

Missed this patch the first time over (thank you lwn :-) - why are you using atomic counters? In all the paths you set them, you already have the queue lock.

Thats right, there's no need for them. I used these instinctively.... Will fix in next version, unless (hint, hint) you're taking a look at adding priorities back to mainline's CFQ.

It will never be for the mainline cfq, that is a dead code base. -mm has a first stab at a cfq v2 with persistent io contexts, the priority based code will go on top of that.

Signature · 1 line
Jens Axboe
#3 lore raw
Quoted 11 lines · Jens Axboe
Quoted 9 lines · Shailabh Nagar
Quoted 6 lines · Jens Axboe

Hi,

Missed this patch the first time over (thank you lwn :-) - why are you using atomic counters? In all the paths you set them, you already have the queue lock.

Quoted 8 lines
Quoted 2 lines

Thats right, there's no need for them. I used these instinctively....
Will fix in next version, unless (hint, hint) you're taking a look at adding priorities back to mainline's CFQ.

It will never be for the mainline cfq, that is a dead code base. -mm has a first stab at a cfq v2 with persistent io contexts, the priority based code will go on top of that.

Great. In CKRM, we'll switch to using -mm's cfq then.

-- Shailabh

author
#4 lore raw
Quoted 18 lines · Shailabh Nagar
Quoted 16 lines · Jens Axboe
Quoted 12 lines · Shailabh Nagar
Quoted 6 lines · Jens Axboe

Hi,

Missed this patch the first time over (thank you lwn :-) - why are you using atomic counters? In all the paths you set them, you already have the queue lock.

Thats right, there's no need for them. I used these instinctively.... Will fix in next version, unless (hint, hint) you're taking a look at adding priorities back to mainline's CFQ.

Quoted 6 lines
Quoted 4 lines

It will never be for the mainline cfq, that is a dead code base. -mm has a first stab at a cfq v2 with persistent io contexts, the priority based code will go on top of that.

Great. In CKRM, we'll switch to using -mm's cfq then.

You'll note that the cic is a per-process-per-queue context, this could hold a reference to whatever CKRM grouping structure you use.

Signature · 1 line
Jens Axboe