Skip to contentSkip to conversation

APIC physical broadcast for i82489DX

PATCH William Lee Irwin III 2 participants 3 messages Oct 7, 2004 1 message not in the archive

lore
Share & tools
lore

A message that is not in the archive (sent off-list or not yet received): [email protected]

#1 lore raw
Quoted 10 lines · Linux Kernel Mailing List

ChangeSet 1.2133, 2004/10/07 08:24:23-07:00, [email protected]
[PATCH] APIC physical broadcast for i82489DX
The physical broadcast ID is determined incorrectly for the i82489DX, which uses 8-bit physical addressing (32-bit logical).

 apic.c |    2 +-
 1 files changed, 1 insertion(+), 1 deletion(-)

diff -Nru a/arch/i386/kernel/apic.c b/arch/i386/kernel/apic.c

arch/i386/kernel/apic.c line 97

Quoted 8 lines
arch/i386/kernel/apic.c +1 -1
@@ -91,7 +91,7 @@
 	unsigned int lvr, version;
 	lvr = apic_read(APIC_LVR);
 	version = GET_APIC_VERSION(lvr);
-	if (version >= 0x14)
+	if (!APIC_INTEGRATED(version) || version >= 0x14)
 		return 0xff;
 	else
 		return 0xf;

This is the same as version <= 0xf || version >= 0x14; I'm rather suspicious, as the docs have long since been purged, making this hopeless for anyone without archives (or a good memory) dating back to that time to check. All that's really needed is citing the version that comes out of the version register and checking other APIC implementations to verify they don't have versions tripping this check, the latter of which is feasible for those relying on still-extant documentation. Better yet would be dredging up the docs... So, what is the range of the version numbers reported by i82489DX's?

-- wli

#2 lore raw
Quoted 11 lines · William Lee Irwin III

Review line 97

Quoted 9 lines
(quoted diff) +1 -1
@@ -91,7 +91,7 @@
 	unsigned int lvr, version;
 	lvr = apic_read(APIC_LVR);
 	version = GET_APIC_VERSION(lvr);
-	if (version >= 0x14)
+	if (!APIC_INTEGRATED(version) || version >= 0x14)
 		return 0xff;
 	else
 		return 0xf;

This is the same as version <= 0xf || version >= 0x14; I'm rather

I suppose defining a macro called something like APIC_XAPIC(x) to (x >=
0x14) might actually have some sense, although unlike with the i82489DX, there is no promise for this to be always true.

Quoted 1 line

suspicious, as the docs have long since been purged, making this

AFAIK i82489DX documents were never available online and I suppose they
might have never existed in a PDF form. You could have ordered hardcopies in mid 90's.

Quoted 4 lines

hopeless for anyone without archives (or a good memory) dating back to that time to check. All that's really needed is citing the version that comes out of the version register and checking other APIC implementations to verify they don't have versions tripping this check,

The APIC_INTEGRATED() macro reflects the range reserved for the i82489DX.
Both "Multiprocessor Specification" and "IA-32 Intel Architecture Software Developer's Manual, Vol.3" which are available online specify it clearly and explicitly. AFAIK, there is no integrated APIC implementation that would violate it (unlike with I/O APICs), so what's the problem? If a buggy chip appears, we can revisit this assumption.

Quoted 3 lines

the latter of which is feasible for those relying on still-extant documentation. Better yet would be dredging up the docs... So, what is the range of the version numbers reported by i82489DX's?

The i82489DX datasheet documents 0x01 for the chip and the
implementations I've encountered so far agree.

Maciej

#3 lore raw
Quoted 1 line · William Lee Irwin III
Quoted 1 line

This is the same as version <= 0xf || version >= 0x14; I'm rather

Quoted 3 lines · Maciej W. Rozycki

I suppose defining a macro called something like APIC_XAPIC(x) to (x >=
0x14) might actually have some sense, although unlike with the i82489DX, there is no promise for this to be always true.

There is a presumption there that higher APIC revisions will be backward-compatible and will have comparable version numbers, yes.

Quoted 1 line · William Lee Irwin III
Quoted 1 line

suspicious, as the docs have long since been purged, making this

Quoted 3 lines · Maciej W. Rozycki

AFAIK i82489DX documents were never available online and I suppose they
might have never existed in a PDF form. You could have ordered hardcopies in mid 90's.

Which probably either predated or coincided with my earliest use of computers.

Quoted 4 lines · William Lee Irwin III
Quoted 4 lines

hopeless for anyone without archives (or a good memory) dating back to that time to check. All that's really needed is citing the version that comes out of the version register and checking other APIC implementations to verify they don't have versions tripping this check,

Quoted 6 lines · Maciej W. Rozycki

The APIC_INTEGRATED() macro reflects the range reserved for the i82489DX.
Both "Multiprocessor Specification" and "IA-32 Intel Architecture Software Developer's Manual, Vol.3" which are available online specify it clearly and explicitly. AFAIK, there is no integrated APIC implementation that would violate it (unlike with I/O APICs), so what's the problem? If a buggy chip appears, we can revisit this assumption.

Only documentation; this is probably as good as it gets, so I'm happy with this level of explanation, for instance, saying what the revision numbers are.

Quoted 3 lines · William Lee Irwin III
Quoted 3 lines

the latter of which is feasible for those relying on still-extant documentation. Better yet would be dredging up the docs... So, what is the range of the version numbers reported by i82489DX's?

Quoted 2 lines · Maciej W. Rozycki

The i82489DX datasheet documents 0x01 for the chip and the
implementations I've encountered so far agree.

Since it's not available online this will have to do. I seem to have turned up some vague evidence they were made into PDF's ca. 1993, but don't really expect that to mean anything.

-- wli