uninitialised flags element could cause crashes
PATCH 1/1 uninitialised flags element could cause crashes
window is not zeroed, so the flags should be assigned, not modified. This can lead to crashes at boot if the IO and Memory resources overlap.
Index: pci-2.6/arch/ia64/pci/pci.c =================================RCS file: /var/cvs/linux-2.6/arch/ia64/pci/pci.c,v retrieving revision 1.15
arch/ia64/pci/pci.c +1 -1
@@ -275,7 +275,7 @@ add_window (struct acpi_resource *res, vreturn AE_OK ; window = &info->controller->window[info->controller->windows++]; - window->resource.flags |= flags; + window->resource.flags = flags; window->resource.start = addr.min_address_range; window->resource.end = addr.max_address_range; window->offset = offset;
Signature · 6 lines
"Next the statesmen will invent cheap lies, putting the blame upon the nation that is attacked, and every man will be glad of those conscience-soothing falsities, and will diligently study them, and refuse to examine any refutations of them; and thus he will by and by convince himself that the war is just, and will thank God for the better sleep he enjoys after this process of grotesque self-deception." -- Mark Twain