Skip to contentSkip to conversation

MS_VERBOSE handling in get_sb_bdev()

RFC Alex Zarochentsev 2 participants 3 messages Oct 14, 2004 – Oct 15, 2004 VFS

lore
Share & tools
lore
#0 lore raw

Hello,

Anybody knows why the "silent" agrument of the fs' ->fill_super() routines is passed as ((flags & MS_VERBOSE) ? 1 : 0) ?. It should be !(flags & MS_VERBOSE) instead, yes?

I don't belive the bug is not known...

Regards,
Alex.

#1 lore raw
Quoted 7 lines · Alex Zarochentsev

Hello,

Anybody knows why the "silent" agrument of the fs' ->fill_super() routines is passed as ((flags & MS_VERBOSE) ? 1 : 0) ?. It should be !(flags & MS_VERBOSE) instead, yes?

I don't belive the bug is not known...

I saw several of those about 1 year ago when I updated Al's fs option patches and got them merged.

They should be fixed IMO, but it's low priority, they work ("it ain't broke so don't fix it"), and maybe someone else thinks that there is no problem at all, i.e., they aren't broken at all...

Signature · 1 line
~Randy
#2 lore raw
Quoted 9 lines · Randy.Dunlap
Quoted 8 lines · Alex Zarochentsev

Hello,

Anybody knows why the "silent" agrument of the fs' ->fill_super() routines is
passed as ((flags & MS_VERBOSE) ? 1 : 0) ?. It should be !(flags & MS_VERBOSE)
instead, yes?

Quoted 8 lines
Quoted 1 line

I don't belive the bug is not known...

I saw several of those about 1 year ago when I updated Al's fs option patches and got them merged.

They should be fixed IMO, but it's low priority, they work ("it ain't broke so don't fix it"), and maybe someone else thinks that there is no problem at all, i.e., they aren't broken at all...

The kernel (2.6.9-rc4) patch is simple
==================================

fs/super.c renamed from fs/super.c.orig +1 -1
@@ -692,7 +692,7 @@ struct super_block *get_sb_bdev(struct f
 		strlcpy(s->s_id, bdevname(bdev, b), sizeof(s->s_id));
 		s->s_old_blocksize = block_size(bdev);
 		sb_set_blocksize(s, s->s_old_blocksize);
-		error = fill_super(s, data, flags & MS_VERBOSE ? 1 : 0);
+		error = fill_super(s, data, !(flags & MS_VERBOSE));
 		if (error) {
 			up_write(&s->s_umount);
 			deactivate_super(s);

==================================

there is another bug in the mount utility, it seems to me. mount never sets MS_VERBOSE. I think it should be set when the mount does not do "fs probing" as in "mount -t auto ".

Quoted 2 lines
Signature · 1 line
~Randy
Signature · 1 line
Alex.