Skip to contentSkip to conversation

unexport ei_tx_timeout

PATCH In review Christoph Hellwig 2 participants 2 messages Oct 24, 2004 – Oct 30, 2004

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 unexport ei_tx_timeout

not used by any module, and the API doesn't make sense as export either

drivers/net/8390.c +0 -1
@@ -1114,7 +1114,6 @@
 #ifdef CONFIG_NET_POLL_CONTROLLER
 EXPORT_SYMBOL(ei_poll);
 #endif
-EXPORT_SYMBOL(ei_tx_timeout);
 EXPORT_SYMBOL(NS8390_init);
 EXPORT_SYMBOL(__alloc_ei_netdev);
 
#1 lore raw
Quoted 1 line · Christoph Hellwig

not used by any module, and the API doesn't make sense as export either

next time include a signed-off-by line.

Also, the API _does_ make sense as an export, as it is a generic helper that can be plugged directly into the netdev->tx_timeout hook.

However, I applied your patch due to the first argument -- no users.

Jeff