Skip to contentSkip to conversation

remove bogus exports in ppp

PATCH In review Christoph Hellwig 3 participants 7 messages Oct 24, 2004 – Jan 27, 2005

Subsystems (2)
Networking Network drivers
lore
Share & tools
lore

Christoph Hellwig

author
#0 lore raw

PATCH 1/1 remove bogus exports in ppp

even if they are usefull for debugging they're just bad namespace pollution for mainline

drivers/net/ppp_generic.c +0 -2
@@ -2721,8 +2721,6 @@
 EXPORT_SYMBOL(ppp_output_wakeup);
 EXPORT_SYMBOL(ppp_register_compressor);
 EXPORT_SYMBOL(ppp_unregister_compressor);
-EXPORT_SYMBOL(all_ppp_units); /* for debugging */
-EXPORT_SYMBOL(all_channels); /* for debugging */
 MODULE_LICENSE("GPL");
 MODULE_ALIAS_CHARDEV_MAJOR(PPP_MAJOR);
 MODULE_ALIAS("/dev/ppp");
author
#1 lore raw
Quoted 2 lines · Christoph Hellwig

even if they are usefull for debugging they're just bad namespace pollution for mainline

ping?

drivers/net/ppp_generic.c +0 -2
@@ -2721,8 +2721,6 @@
 EXPORT_SYMBOL(ppp_output_wakeup);
 EXPORT_SYMBOL(ppp_register_compressor);
 EXPORT_SYMBOL(ppp_unregister_compressor);
-EXPORT_SYMBOL(all_ppp_units); /* for debugging */
-EXPORT_SYMBOL(all_channels); /* for debugging */
 MODULE_LICENSE("GPL");
 MODULE_ALIAS_CHARDEV_MAJOR(PPP_MAJOR);
 MODULE_ALIAS("/dev/ppp");
Acked-by
#2 lore raw

drivers/net/ppp_generic.c line 2726

Quoted 13 lines · Christoph Hellwig

ping?

drivers/net/ppp_generic.c +0 -2
@@ -2721,8 +2721,6 @@
 EXPORT_SYMBOL(ppp_output_wakeup);
 EXPORT_SYMBOL(ppp_register_compressor);
 EXPORT_SYMBOL(ppp_unregister_compressor);
-EXPORT_SYMBOL(all_ppp_units); /* for debugging */
-EXPORT_SYMBOL(all_channels); /* for debugging */
 MODULE_LICENSE("GPL");
 MODULE_ALIAS_CHARDEV_MAJOR(PPP_MAJOR);
 MODULE_ALIAS("/dev/ppp");
Acked-by Paul Mackerras <[email protected]>
author
#3 lore raw
In reply to Christoph Hellwig
Quoted 2 lines · Christoph Hellwig

even if they are usefull for debugging they're just bad namespace pollution for mainline

ping?

Signed-off-by Christoph Hellwig <[email protected]>
drivers/net/ppp_generic.c +0 -2
@@ -2721,8 +2721,6 @@
 EXPORT_SYMBOL(ppp_output_wakeup);
 EXPORT_SYMBOL(ppp_register_compressor);
 EXPORT_SYMBOL(ppp_unregister_compressor);
-EXPORT_SYMBOL(all_ppp_units); /* for debugging */
-EXPORT_SYMBOL(all_channels); /* for debugging */
 MODULE_LICENSE("GPL");
 MODULE_ALIAS_CHARDEV_MAJOR(PPP_MAJOR);
 MODULE_ALIAS("/dev/ppp");
maintainer
#4 lore raw
Quoted 7 lines · On Thu, 27 Jan 2005 12:22:19 +0100 Christoph Hellwig <[email protected]> wrote:
Quoted 2 lines · Christoph Hellwig

even if they are usefull for debugging they're just bad namespace pollution for mainline

ping?

Signed-off-by Christoph Hellwig <[email protected]>

I've already gotten a light slap on the hand for removing module exports in 2.6.x, so we might want to skip on this one.

author
#5 lore raw
Quoted 16 lines · David S. Miller
Quoted 7 lines · On Thu, 27 Jan 2005 12:22:19 +0100 Christoph Hellwig <[email protected]> wrote:
Quoted 2 lines · Christoph Hellwig

even if they are usefull for debugging they're just bad namespace pollution for mainline

ping?

Signed-off-by Christoph Hellwig <[email protected]>

I've already gotten a light slap on the hand for removing module exports in 2.6.x, so we might want to skip on this one.

From whom?