2.6.10-rc1-kjt1

announce maximilian attems 5 participants 8 messages Oct 24, 2004 – Nov 20, 2004

Subsystems (2)

Network drivers Kernel janitors

lore

Share & tools

lore

maximilian attems

author

2004-10-24 15:12 UTC #0 lore raw

lots of patches got merged! :)
2.6.9-kjt1 "died" in quick race after a few days. rediffed to have a better base to push current patches soon.

new patches from nacc and domen.
diffstat (minus the pci patches) shows a lot under drivers/{block,net}.

please test out:
http://debian.stro.at/kjt/2.6.10-rc1-kjt1/2.6.10-rc1-kjt1.patch.bz2

splitted out 168 patches:
http://debian.stro.at/kjt/2.6.10-rc1-kjt1/split/

thanks for feedback.
maks

~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
added since 2.6.9-kjt1

fix-comment-fs_jbd_journal.patch
From: Domen Puncer <[email protected]>
Subject: [KJ] [patch] jbd: remove comment in journal.c

lib-parser-fs_devpts_inode.patch
From: Domen Puncer <[email protected]>
Subject: [KJ] [patch] fs/devpts: use lib/parser

msleep-drivers_pci_quirks.patch
From: Nishanth Aravamudan <[email protected]>
Subject: [KJ] [PATCH] pci/quirks: replace schedule_timeout() with msleep()

msleep_interruptible-drivers_cdrom_sonycd535_2.patch
From: Nishanth Aravamudan <[email protected]>
Subject: [KJ] [PATCH] cdrom/sonycd535: replace schedule_timeout() with msleep_interruptible()

msleep_interruptible-drivers_message_fusion_mptbase.patch
From: Nishanth Aravamudan <[email protected]>
Subject: [KJ] [PATCH] message/mptbase: replace schedule_timeout() with msleep_interruptible()

msleep_interruptible-drivers_net_ewrk3.patch
From: Nishanth Aravamudan <[email protected]>
Subject: [KJ] [PATCH] net/ewrk3: replace schedule_timeout() with msleep_interruptible()

msleep_interruptible-drivers_w1_dscore.patch
From: Nishanth Aravamudan <[email protected]>
Subject: [KJ] [PATCH] w1/dscore: replace schedule_timeout() with msleep_interruptible()

msleep_interruptible-drivers_w1_w1_family.patch
From: Nishanth Aravamudan <[email protected]>
Subject: [KJ] [PATCH] w1/w1_family: replace schedule_timeout() with msleep_interruptible()

msleep_interruptible-drivers_w1_w1_int.patch
From: Nishanth Aravamudan <[email protected]>
Subject: [KJ] [PATCH] w1/w1_int: replace schedule_timeout() with msleep_interruptible()

msleep_interruptible-drivers_w1_w1.patch
From: Nishanth Aravamudan <[email protected]>
Subject: [KJ] [PATCH] w1/w1: replace schedule_timeout() with msleep_interruptible()

msleep+ssleep-drivers_scsi_ahci.patch
From: Nishanth Aravamudan <[email protected]>
Subject: [KJ] [PATCH] scsi/ahci: replace schedule_timeout() with msleep()/ssleep()

reorder-state-drivers_char_snsc.patch
From: Nishanth Aravamudan <[email protected]>
Subject: [KJ] [PATCH] char/snsc: reorder set_current_state() and add_wait_queue()

reorder-state-drivers_video_pxafb.patch
From: Nishanth Aravamudan <[email protected]>
Subject: [KJ] [PATCH] video/pxafb: reorder add_wait_queue() and set_current_state()

reorder-state-drivers_video_sa1100fb.patch
From: Nishanth Aravamudan <[email protected]>
Subject: [KJ] [PATCH] video/sa1100fb: reorder set_current_state() and add_wait_queue()

set_current_state-drivers_input_joystick_iforce_iforce-packets.patch
From: Nishanth Aravamudan <[email protected]>
Subject: [KJ] [PATCH] input/iforce-packets: insert set_current_state() before schedule_timeout()

ssleep-drivers_scsi_qla2xxx_qla_os.patch
From: Nishanth Aravamudan <[email protected]>
Subject: [KJ] [PATCH] scsi/qla_os: replace schedule_timeout() with ssleep()

~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
reworked

remove-old-ifdefs-aic7xxx_osm_pci.patch
due to rejects and bogus previous rework
(keeps 2.4 compatibility)

msleep_interruptible-drivers_serial_68328serial.patch msleep_interruptible-drivers_serial_mcfserial.patch due to rejects

msleep_interruptible-drivers_media_video_msp3400.patch msleep-drivers_net_wireless_prism54_islpci_dev.patch partially merged

~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
merged 34 patches up to latest -rc:

min-max-arch_m68k_kernel_bios32.patch modern-init-drivers_atm_zatm.patch msleep-drivers_media_dvb_b2c2_skystar2.patch msleep-drivers_media_dvb_dvb-core_dvb_ca_en50221.patch msleep-drivers_media_dvb_dvb-core_dvb_frontend.patch msleep-drivers_media_dvb_frontends_alps_tdmb7.patch msleep-drivers_media_dvb_frontends_at76c651.patch msleep-drivers_media_dvb_frontends_cs24110.patch msleep-drivers_media_dvb_frontends_dst.patch msleep-drivers_media_dvb_frontends_grundig_29504-401.patch msleep-drivers_media_dvb_frontends_grundig_29504-491.patch msleep-drivers_media_dvb_frontends_stv0299.patch msleep-drivers_media_dvb_frontends_tda1004x.patch msleep-drivers_media_dvb_frontends_ves1820.patch msleep-drivers_media_dvb_frontends_ves1x93.patch msleep-drivers_media_dvb_ttpci_av7110_hw.patch msleep-drivers_media_dvb_ttpci_av7110.patch msleep-drivers_media_dvb_ttpci_av7110_v4l.patch msleep-drivers_media_dvb_ttpci_budget-av.patch msleep-drivers_media_dvb_ttpci_budget-ci.patch msleep-drivers_media_dvb_ttpci_budget.patch msleep-drivers_media_video_bttv-driver.patch msleep_interruptible-drivers_media_video_bttv-i2c.patch msleep_interruptible-drivers_media_video_cx88_cx88-tvaudio.patch msleep_interruptible-drivers_media_video_cx88_cx88-video.patch msleep_interruptible-drivers_media_video_saa6752hs.patch msleep_interruptible-drivers_media_video_saa7134_saa7134-core.patch msleep_interruptible-drivers_media_video_saa7134_saa7134-ts.patch msleep_interruptible-drivers_media_video_saa7134_saa7134-tvaudio.patch pci_dev_present-drivers_media_video_bttv-driver.patch printk-net_wireless_prism54_islpci_mgt.h.patch msleep-drivers_char_sis-agp.patch msleep_interruptible-drivers_char_amiserial.patch msleep_interruptible-drivers_char_cyclades.patch

~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
dropped

msleep-drivers_media_dvb_dvb-core_dvb_functions.patch file removed

~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
todo:
- split kernel_thread() patches from Walter Harms
- look at the new patches from Walter Harms
- look at dprintk patches from Daniele Pizzoni

_______________________________________________
Kernel-janitors mailing list
[email protected]
http://lists.osdl.org/mailman/listinfo/kernel-janitors

Adrian Bunk

2004-10-29 23:51 UTC #1 lore raw

2.6.10-rc1-kjt1: ixgb_ethtool.c doesn't compile

Quoted 3 lines · maximilian attems

...
splitted out 168 patches:
http://debian.stro.at/kjt/2.6.10-rc1-kjt1/split/

Could you provide a .tar.gz (or .tar.bz) of the splitted patches (similar to how Andrew does for -mm)?

Quoted 3 lines

thanks for feedback.
maks
...

msleep_interruptible-drivers_net_ixgb_ixgb_ethtool.patch doesn't compile:

<-- snip -->

...
CC drivers/net/ixgb/ixgb_ethtool.o
drivers/net/ixgb/ixgb_ethtool.c: In function `ixgb_ethtool_led_blink':
drivers/net/ixgb/ixgb_ethtool.c:407: error: `id' undeclared (first use in this function) drivers/net/ixgb/ixgb_ethtool.c:407: error: (Each undeclared identifier is reported only once drivers/net/ixgb/ixgb_ethtool.c:407: error: for each function it appears in.) make[3]: *** [drivers/net/ixgb/ixgb_ethtool.o] Error 1

<-- snip -->

cu
Adrian

Signature · 4 lines

       "Is there not promise of rain?" Ling Tan asked suddenly out
        of the darkness. There had been need of rain for many days.
       "Only a promise," Lao Er said.
                                       Pearl S. Buck - Dragon Seed

_______________________________________________
Kernel-janitors mailing list
[email protected]
http://lists.osdl.org/mailman/listinfo/kernel-janitors

Randy.Dunlap

2004-10-30 00:26 UTC #2 lore raw

Re: [KJ] 2.6.10-rc1-kjt1: ixgb_ethtool.c doesn't compile

Quoted 18 lines · Adrian Bunk

Quoted 1 line · maximilian attems
...
msleep_interruptible-drivers_net_ixgb_ixgb_ethtool.patch doesn't compile:
<-- snip -->
...
CC drivers/net/ixgb/ixgb_ethtool.o
drivers/net/ixgb/ixgb_ethtool.c: In function `ixgb_ethtool_led_blink':
drivers/net/ixgb/ixgb_ethtool.c:407: error: `id' undeclared (first use in this function) drivers/net/ixgb/ixgb_ethtool.c:407: error: (Each undeclared identifier is reported only once drivers/net/ixgb/ixgb_ethtool.c:407: error: for each function it appears in.) make[3]: *** [drivers/net/ixgb/ixgb_ethtool.o] Error 1

Quoted 1 line

<-- snip -->

There are new (large) patches to the ixgb driver too. See:
http://oss.sgi.com/projects/netdev/archive/2004-10/msg01342.html

Signature · 5 lines

~Randy
_______________________________________________
Kernel-janitors mailing list
[email protected]
http://lists.osdl.org/mailman/listinfo/kernel-janitors

Nish Aravamudan

2004-10-30 04:44 UTC #3 lore raw

Re: [KJ] 2.6.10-rc1-kjt1: ixgb_ethtool.c doesn't compile

In reply to Adrian Bunk

Quoted 7 lines · Adrian Bunk

Quoted 3 lines · maximilian attems
...
splitted out 168 patches:
http://debian.stro.at/kjt/2.6.10-rc1-kjt1/split/
Could you provide a .tar.gz (or .tar.bz) of the splitted patches (similar to how Andrew does for -mm)?

Do you mean like the one he provided?

please test out:
http://debian.stro.at/kjt/2.6.10-rc1-kjt1/2.6.10-rc1-kjt1.patch.bz2

Admittedly, it's not tarred first, but still... Maybe you mean something else, though, and I'm just confused.

Quoted 9 lines

Quoted 3 lines
thanks for feedback.
maks
...
msleep_interruptible-drivers_net_ixgb_ixgb_ethtool.patch doesn't compile:
<-- snip -->

Quoted 7 lines

...
CC drivers/net/ixgb/ixgb_ethtool.o
drivers/net/ixgb/ixgb_ethtool.c: In function `ixgb_ethtool_led_blink':
drivers/net/ixgb/ixgb_ethtool.c:407: error: `id' undeclared (first use in this function) drivers/net/ixgb/ixgb_ethtool.c:407: error: (Each undeclared identifier is reported only once drivers/net/ixgb/ixgb_ethtool.c:407: error: for each function it appears in.) make[3]: *** [drivers/net/ixgb/ixgb_ethtool.o] Error 1

Thanks for catching this, I will make the change to the patch tomorrow and send it again.

-Nish

_______________________________________________
Kernel-janitors mailing list
[email protected]
http://lists.osdl.org/mailman/listinfo/kernel-janitors

Adrian Bunk

2004-10-30 05:09 UTC #4 lore raw

Re: [KJ] 2.6.10-rc1-kjt1: ixgb_ethtool.c doesn't compile

Quoted 9 lines · Nish Aravamudan

Quoted 7 lines · Adrian Bunk
Quoted 3 lines · maximilian attems
...
splitted out 168 patches:
http://debian.stro.at/kjt/2.6.10-rc1-kjt1/split/
Could you provide a .tar.gz (or .tar.bz) of the splitted patches (similar to how Andrew does for -mm)?

Quoted 8 lines

Do you mean like the one he provided?
please test out:
http://debian.stro.at/kjt/2.6.10-rc1-kjt1/2.6.10-rc1-kjt1.patch.bz2
Admittedly, it's not tarred first, but still... Maybe you mean something else, though, and I'm just confused.
...

No, I'd like to have a .tar.gz of the split directory, similar to ftp://ftp.kernel.org/pub/linux/kernel/people/akpm/patches/2.6/2.6.9/2.6.9-mm1/2.6.9-mm1-broken-out.tar.gz

This way, it would be easier to simply grep for a file causing a problem.

Quoted 1 line

-Nish

cu
Adrian

Signature · 4 lines

       "Is there not promise of rain?" Ling Tan asked suddenly out
        of the darkness. There had been need of rain for many days.
       "Only a promise," Lao Er said.
                                       Pearl S. Buck - Dragon Seed

_______________________________________________
Kernel-janitors mailing list
[email protected]
http://lists.osdl.org/mailman/listinfo/kernel-janitors

maximilian attems

author

2004-10-30 15:08 UTC #5 lore raw

Re: [KJ] 2.6.10-rc1-kjt1: ixgb_ethtool.c doesn't compile

Quoted 15 lines · Adrian Bunk

Quoted 14 lines · Nish Aravamudan
Quoted 7 lines · Adrian Bunk
Quoted 3 lines · maximilian attems
...
splitted out 168 patches:
http://debian.stro.at/kjt/2.6.10-rc1-kjt1/split/
Could you provide a .tar.gz (or .tar.bz) of the splitted patches (similar to how Andrew does for -mm)?
Do you mean like the one he provided?
please test out:
http://debian.stro.at/kjt/2.6.10-rc1-kjt1/2.6.10-rc1-kjt1.patch.bz2

Quoted 6 lines

Quoted 3 lines
Admittedly, it's not tarred first, but still... Maybe you mean something else, though, and I'm just confused.
...
No, I'd like to have a .tar.gz of the split directory, similar to ftp://ftp.kernel.org/pub/linux/kernel/people/akpm/patches/2.6/2.6.9/2.6.9-mm1/2.6.9-mm1-broken-out.tar.gz

thanks for the idea! done for all the older kjt releases. you'll find latest:
http://debian.stro.at/kjt/2.6.10-rc1-kjt1/2.6.10-rc1-kjt1-split.tar.bz2
http://debian.stro.at/kjt/2.6.10-rc1-kjt1/2.6.10-rc1-kjt1-split.tar.gz

Quoted 2 lines

This way, it would be easier to simply grep for a file causing a problem.

thanks a lot for the testing.

--
maks
kernel janitor http://janitor.kernelnewbies.org/

_______________________________________________
Kernel-janitors mailing list
[email protected]
http://lists.osdl.org/mailman/listinfo/kernel-janitors

Nishanth Aravamudan

2004-10-30 22:52 UTC #6 lore raw

Re: 2.6.10-rc1-kjt1: ixgb_ethtool.c doesn't compile

In reply to Adrian Bunk

Quoted 17 lines · Adrian Bunk

Quoted 3 lines · maximilian attems
...
splitted out 168 patches:
http://debian.stro.at/kjt/2.6.10-rc1-kjt1/split/
Could you provide a .tar.gz (or .tar.bz) of the splitted patches (similar to how Andrew does for -mm)?
Quoted 3 lines
thanks for feedback.
maks
...
msleep_interruptible-drivers_net_ixgb_ixgb_ethtool.patch doesn't compile:
<-- snip -->

Quoted 7 lines

...
CC drivers/net/ixgb/ixgb_ethtool.o
drivers/net/ixgb/ixgb_ethtool.c: In function `ixgb_ethtool_led_blink':
drivers/net/ixgb/ixgb_ethtool.c:407: error: `id' undeclared (first use in this function) drivers/net/ixgb/ixgb_ethtool.c:407: error: (Each undeclared identifier is reported only once drivers/net/ixgb/ixgb_ethtool.c:407: error: for each function it appears in.) make[3]: *** [drivers/net/ixgb/ixgb_ethtool.o] Error 1

Here's the corrected patch, thanks again for catching this Adrian:

Description: Uses msleep_interruptible() instead of schedule_timeout() to guarantee the task delays as expected.

Signed-off-by Nishanth Aravamudan <[email protected]>

drivers/net/ixgb/ixgb_ethtool.c +3 -3

@@ -31,6 +31,7 @@
 #include "ixgb.h"
 
 #include <asm/uaccess.h>
+#include <linux/delay.h>
 
 extern char ixgb_driver_name[];
 extern char ixgb_driver_version[];

@@ -402,11 +403,10 @@ ixgb_ethtool_led_blink(struct net_device
 
 	mod_timer(&adapter->blink_timer, jiffies);
 
-	set_current_state(TASK_INTERRUPTIBLE);
 	if (data)
-		schedule_timeout(data * HZ);
+		msleep_interruptible(data * 1000);
 	else
-		schedule_timeout(MAX_SCHEDULE_TIMEOUT);
+		msleep_interruptible(jiffies_to_msecs(MAX_SCHEDULE_TIMEOUT));
 
 	del_timer_sync(&adapter->blink_timer);
 	ixgb_led_off(&adapter->hw);

_______________________________________________
Kernel-janitors mailing list
[email protected]
http://lists.osdl.org/mailman/listinfo/kernel-janitors

maximilian attems

author

2004-11-20 02:18 UTC #7 lore raw

[announce] 2.6.10-rc2-kjt1 patchset

In reply to maximilian attems

new janitorial stuff mostly under drivers.
again lots of patches got merged, thanks gregkh, akpm and linus.

patches resulted in nice discussions about msleep() and friends on the #kerneljanitor channel. :)
until better solutions are merged the msleep_interruptible() patches are frozen. others will be sent upstream.

please test out (based on 2.6.10-rc2-bk4):
http://debian.stro.at/kjt/2.6.10-rc2-kjt1/2.6.10-rc2-kjt1.patch.bz2

splitted out 130 patches (based on 2.6.10-rc2-bk4):
http://debian.stro.at/kjt/2.6.10-rc2-kjt1/2.6.10-rc2-kjt1-split.patch.bz2

thanks for feedback.
a++ maks

~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
added since 2.6.10-rc1-kjt1