Unwind information fix for the vsyscall DSO
When working on GDB support I found a typo. I assume the comment is correct. If you step to this particular instruction and backtrace, GDB gets lost.
I haven't tested the fixed version yet, but I'm pretty confident in this patch :-) Please apply.
i386/kernel/vsyscall-sysenter.S renamed from i386/kernel/vsyscall-sysenter.S.orig +1 -1
@@ -84,7 +84,7 @@ .byte 0x04 /* DW_CFA_advance_loc4 */ .long .Lpop_ebp-.Lenter_kernel .byte 0x0e /* DW_CFA_def_cfa_offset */ - .byte 0x12 /* RA at offset 12 now */ + .byte 0x0c /* RA at offset 12 now */ .byte 0xc5 /* DW_CFA_restore %ebp */ .byte 0x04 /* DW_CFA_advance_loc4 */ .long .Lpop_edx-.Lpop_ebp
Signature · 1 line
Daniel Jacobowitz
Quoted 7 lines · Daniel Jacobowitz
When working on GDB support I found a typo. I assume the comment is correct. If you step to this particular instruction and backtrace, GDB gets lost.
I haven't tested the fixed version yet, but I'm pretty confident in this patch :-) Please apply.
The patch looks obvious, but I'd still like to see a "yeah, I tested it now, and yes, gdb DTRT after the fix.."
Linus
Quoted 8 lines · Linus Torvalds
Quoted 5 lines · Daniel Jacobowitz
When working on GDB support I found a typo. I assume the comment is correct. If you step to this particular instruction and backtrace, GDB gets lost.
Quoted 5 lines
Quoted 2 lines
I haven't tested the fixed version yet, but I'm pretty confident in this patch :-) Please apply.
The patch looks obvious, but I'd still like to see a "yeah, I tested it now, and yes, gdb DTRT after the fix.."
It looks good, but it triggered a related bug in GDB and 2.6.10-rc1 locked up while I was debugging that. I'll get back to you once I can test it.
Signature · 1 line
Daniel Jacobowitz