Skip to contentSkip to conversation

Kill useless pm_access from vt.c

PATCH Pavel Machek 1 participant 1 message Oct 25, 2004

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

Hi!

pm_access does nothing these days, and looks ugly. This removes it from vt.c. That actually looks like last user in the tree; it should be possible to kill pm_access completely after 2.6.10. Ouch and add warning to obsolete pm.txt file. Please apply,

Pavel

drivers/char/vt.c +0 -6
@@ -2186,8 +2186,6 @@
 	if (!printable || test_and_set_bit(0, &printing))
 		return;
 
-	pm_access(pm_con);
-
 	if (kmsg_redirect && vc_cons_allocated(kmsg_redirect - 1))
 		currcons = kmsg_redirect - 1;
 
@@ -2387,7 +2385,6 @@
 {
 	int	retval;
 
-	pm_access(pm_con);
 	retval = do_con_write(tty, from_user, buf, count);
 	con_flush_chars(tty);
 
@@ -2398,7 +2395,6 @@
 {
 	if (in_interrupt())
 		return;	/* n_r3964 calls put_char() from interrupt context */
-	pm_access(pm_con);
 	do_con_write(tty, 0, &ch, 1);
 }
 
@@ -2467,8 +2463,6 @@
 	if (in_interrupt())	/* from flush_to_ldisc */
 		return;
 
-	pm_access(pm_con);
-	
 	/* if we race with con_close(), vt may be null */
 	acquire_console_sem();
 	vt = tty->driver_data;
Documentation/pm.txt +4 -4
@@ -36,8 +36,8 @@
   apmd:   http://worldvisions.ca/~apenwarr/apmd/
   acpid:  http://acpid.sf.net/
 
-Driver Interface
-----------------
+Driver Interface -- OBSOLETE, DO NOT USE!
+----------------*************************
 If you are writing a new driver or maintaining an old driver, it
 should include power management support.  Without power management
 support, a single driver may prevent a system with power management
@@ -262,8 +262,8 @@
 
 ACPI Development mailing list: [email protected]
 
-System Interface
-----------------
+System Interface -- OBSOLETE, DO NOT USE!
+----------------*************************
 If you are providing new power management support to Linux (ie.
 adding support for something like APM or ACPI), you should
 communicate with drivers through the existing generic power
Signature · 2 lines
People were complaining that M$ turns users into beta-testers...
...jr ghea gurz vagb qrirybcref, naq gurl frrz gb yvxr vg gung jnl!