Skip to contentSkip to conversation

appletalk: remove an unused function

PATCH In review Adrian Bunk 4 participants 6 messages Oct 28, 2004 – Nov 2, 2004

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 appletalk: remove an unused function

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

The patch below removes an unsed function from net/appletalk/ddp.c

diffstat output:

 net/appletalk/ddp.c |    7 -------
 1 files changed, 7 deletions(-)

- --- linux-2.6.10-rc1-mm1-full/net/appletalk/ddp.c.old 2004-10-28 23:49:44.000000000 +0200
+++ linux-2.6.10-rc1-mm1-full/net/appletalk/ddp.c 2004-10-28 23:49:57.000000000 +0200
@@ -78,13 +78,6 @@
sk_add_node(sk, &atalk_sockets);
}

- -static inline void atalk_insert_socket(struct sock *sk)
- -{
- - write_lock_bh(&atalk_sockets_lock);
- - __atalk_insert_socket(sk);
- - write_unlock_bh(&atalk_sockets_lock);
- -}
- -
static inline void atalk_remove_socket(struct sock *sk) {
write_lock_bh(&atalk_sockets_lock);

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.6 (GNU/Linux)

iD8DBQFBgW5mmfzqmE8StAARAvaMAJ94zqUtcUYZKMtwHKnTtKof9ew9pACeJIoT d7KwwwKipvnGxnCmnwf8U0E=
=xXRj
-----END PGP SIGNATURE-----

maintainer
#1 lore raw
Quoted 7 lines · On Fri, 29 Oct 2004 00:10:46 +0200 Adrian Bunk <[email protected]> wrote:

- -static inline void atalk_insert_socket(struct sock *sk)
- -{
- - write_lock_bh(&atalk_sockets_lock);
- - __atalk_insert_socket(sk);
- - write_unlock_bh(&atalk_sockets_lock);
- -}
- -

This is a patch of a patch, I doubt it will apply cleanly ;-)

#2 lore raw
Quoted 11 lines · David S. Miller
Quoted 7 lines · On Fri, 29 Oct 2004 00:10:46 +0200 Adrian Bunk <[email protected]> wrote:

- -static inline void atalk_insert_socket(struct sock *sk)
- -{
- - write_lock_bh(&atalk_sockets_lock);
- - __atalk_insert_socket(sk);
- - write_unlock_bh(&atalk_sockets_lock);
- -}
- -

Quoted 1 line

This is a patch of a patch, I doubt it will apply cleanly ;-)

Ditto, all the patches sent to me look like this, too.

Jeff

#4 lore raw

PATCH 1/1 appletalk: remove an unused function

In reply to Adrian Bunk

[ this time without the problems due to a digital signature... ]

The patch below removes an unsed function from net/appletalk/ddp.c

diffstat output:

 net/appletalk/ddp.c |    7 -------
 1 files changed, 7 deletions(-)
net/appletalk/ddp.c renamed from net/appletalk/ddp.c.old +0 -7
@@ -78,13 +78,6 @@
 	sk_add_node(sk, &atalk_sockets);
 }
 
-static inline void atalk_insert_socket(struct sock *sk)
-{
-	write_lock_bh(&atalk_sockets_lock);
-	__atalk_insert_socket(sk);
-	write_unlock_bh(&atalk_sockets_lock);
-}
-
 static inline void atalk_remove_socket(struct sock *sk)
 {
 	write_lock_bh(&atalk_sockets_lock);
#3 lore raw
In reply to David S. Miller
Quoted 1 line · David S. Miller

This is a patch of a patch, I doubt it will apply cleanly ;-)

Note if you run it through gpg/pgp decoding it will output the real patch (my mail client does this automatically, so the comments saying the patches were screwed up were very confusing at first!).

-Miles

Signature · 1 line
Run away!  Run away!