Skip to contentSkip to conversation

netfilter/ipt_tcpmss.c: remove an unused function

PATCH New Adrian Bunk 2 participants 3 messages Oct 28, 2004 – Nov 2, 2004

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 netfilter/ipt_tcpmss.c: remove an unused function

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

The patch below removes an unused function from
net/ipv4/netfilter/ipt_tcpmss.c

diffstat output:

 net/ipv4/netfilter/ipt_tcpmss.c |   12 ------------
 1 files changed, 12 deletions(-)

- --- linux-2.6.10-rc1-mm1-full/net/ipv4/netfilter/ipt_tcpmss.c.old 2004-10-28 23:51:17.000000000 +0200
+++ linux-2.6.10-rc1-mm1-full/net/ipv4/netfilter/ipt_tcpmss.c 2004-10-28 23:51:28.000000000 +0200
@@ -87,18 +87,6 @@
info->invert, hotdrop);
}

- -static inline int find_syn_match(const struct ipt_entry_match *m)
- -{
- - const struct ipt_tcp *tcpinfo = (const struct ipt_tcp *)m->data;
- -
- - if (strcmp(m->u.kernel.match->name, "tcp") == 0
- - && (tcpinfo->flg_cmp & TH_SYN)
- - && !(tcpinfo->invflags & IPT_TCP_INV_FLAGS))
- - return 1;
- -
- - return 0;
- -}
- -
static int
checkentry(const char *tablename,
const struct ipt_ip *ip,

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.6 (GNU/Linux)

iD8DBQFBgXpqmfzqmE8StAARAlfTAJ9tZB577aVYlmz3j91H4DvBkX4KMwCglbcK xolcBq4HFXSsy8N9BZIJiW8=
=pbup
-----END PGP SIGNATURE-----

#1 lore raw

PATCH 1/1 netfilter/ipt_tcpmss.c: remove an unused function

[ this time without the problems due to a digital signature... ]

The patch below removes an unused function from
net/ipv4/netfilter/ipt_tcpmss.c

diffstat output:

 net/ipv4/netfilter/ipt_tcpmss.c |   12 ------------
 1 files changed, 12 deletions(-)
net/ipv4/netfilter/ipt_tcpmss.c renamed from net/ipv4/netfilter/ipt_tcpmss.c.old +0 -12
@@ -87,18 +87,6 @@
 			       info->invert, hotdrop);
 }
 
-static inline int find_syn_match(const struct ipt_entry_match *m)
-{
-	const struct ipt_tcp *tcpinfo = (const struct ipt_tcp *)m->data;
-
-	if (strcmp(m->u.kernel.match->name, "tcp") == 0
-	    && (tcpinfo->flg_cmp & TH_SYN)
-	    && !(tcpinfo->invflags & IPT_TCP_INV_FLAGS))
-		return 1;
-
-	return 0;
-}
-
 static int
 checkentry(const char *tablename,
            const struct ipt_ip *ip,
maintainer Applied
#2 lore raw
Quoted 2 lines · On Fri, 29 Oct 2004 02:21:13 +0200 Adrian Bunk <[email protected]> wrote:

The patch below removes an unused function from
net/ipv4/netfilter/ipt_tcpmss.c

Applied, thanks Adrian. This one is probably due to cut&paste from ipt_TCPMSS.c where this inline is also implemented and also actually used :-)