Skip to contentSkip to conversation

net/typhoon.c: remove an unused function

PATCH NAK Adrian Bunk 2 participants 2 messages Oct 28, 2004 – Oct 29, 2004 Network drivers

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 net/typhoon.c: remove an unused function

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

The patch below removes an unused function from drivers/net/typhoon.c

diffstat output:

 drivers/net/typhoon.c |    8 --------
 1 files changed, 8 deletions(-)

- --- linux-2.6.10-rc1-mm1-full/drivers/net/typhoon.c.old 2004-10-28 23:21:30.000000000 +0200
+++ linux-2.6.10-rc1-mm1-full/drivers/net/typhoon.c 2004-10-28 23:21:44.000000000 +0200
@@ -372,14 +372,6 @@
typhoon_inc_index(index, count, TXLO_ENTRIES);
}

- -static inline void
- -typhoon_inc_rx_index(u32 *index, const int count)
- -{
- - /* sizeof(struct rx_desc) != sizeof(struct cmd_desc) */
- - *index += count * sizeof(struct rx_desc);
- - *index %= RX_ENTRIES * sizeof(struct rx_desc);
- -}
- -
static int
typhoon_reset(void __iomem *ioaddr, int wait_type) {

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.6 (GNU/Linux)

iD8DBQFBgXt1mfzqmE8StAARAkWAAJ0dshTZ/dXqh+UdamvhZCzGA6cqvQCggWQf JtBs+VjssQpn02lnVV9MhmA=
=6yW2
-----END PGP SIGNATURE-----

#1 lore raw
Quoted 4 lines · Adrian Bunk

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

The patch below removes an unused function from drivers/net/typhoon.c

NAK -- I'd prefer to make it be used, which was the reason it was there in the first place... not sure why it wasn't...

===== drivers/net/typhoon.c 1.25 vs edited =====

drivers/net/typhoon.c +1 -2
@@ -1687,8 +1687,7 @@
 		skb = rxb->skb;
 		dma_addr = rxb->dma_addr;
 
-		rxaddr += sizeof(struct rx_desc);
-		rxaddr %= RX_ENTRIES * sizeof(struct rx_desc);
+		typhoon_inc_rx_index(&rxaddr, 1);
 
 		if(rx->flags & TYPHOON_RX_ERROR) {
 			typhoon_recycle_rx_skb(tp, idx);