Skip to contentSkip to conversation

sched.c: remove an unused function

PATCH In review Adrian Bunk 3 participants 6 messages Oct 28, 2004 – Oct 29, 2004 1 message not in the archive

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 sched.c: remove an unused function

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

The patch below removes an unused function from kernel/sched.c

diffstat output:

 kernel/sched.c |    5 -----
 1 files changed, 5 deletions(-)

- --- linux-2.6.10-rc1-mm1-full/kernel/sched.c.old 2004-10-28 22:33:14.000000000 +0200
+++ linux-2.6.10-rc1-mm1-full/kernel/sched.c 2004-10-28 22:34:47.000000000 +0200
@@ -438,11 +438,6 @@
return rq;
}

- -static inline void rq_unlock(runqueue_t *rq)
- -{
- - spin_unlock_irq(&rq->lock);
- -}
- -
#ifdef CONFIG_SCHEDSTATS
/*
* Called when a process is dequeued from the active array and given

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.6 (GNU/Linux)

iD8DBQFBgX1lmfzqmE8StAARAva8AKCKU+UIq++mdjpHqK4YbvoXmGBAwwCfS7OY p7bxTJ7cdG5gZCkWhPWCyVc=
=UigC
-----END PGP SIGNATURE-----

#1 lore raw

PATCH 1/1 sched.c: remove an unused function

[ this time without the problems due to a digital signature... ]

The patch below removes an unused function from kernel/sched.c

diffstat output:

 kernel/sched.c |    5 -----
 1 files changed, 5 deletions(-)
kernel/sched.c renamed from kernel/sched.c.old +0 -5
@@ -438,11 +438,6 @@
 	return rq;
 }
 
-static inline void rq_unlock(runqueue_t *rq)
-{
-	spin_unlock_irq(&rq->lock);
-}
-
 #ifdef CONFIG_SCHEDSTATS
 /*
  * Called when a process is dequeued from the active array and given
#4 lore raw

PATCH 1/1 sched.c: remove an unused macro

In reply to a message not in the archive
Quoted 3 lines · Peter Williams

You missed some :-). The cpu_to_node_mask() macros don't seem to be used either.

I only searched for unused static inline functions (since this was relatively easy).

But your comment seems to be correct, and below is the patch that removes the cpu_to_node_mask macros.

kernel/sched.c renamed from kernel/sched.c.old +0 -6
@@ -51,12 +51,6 @@
 
 #include <asm/unistd.h>
 
-#ifdef CONFIG_NUMA
-#define cpu_to_node_mask(cpu) node_to_cpumask(cpu_to_node(cpu))
-#else
-#define cpu_to_node_mask(cpu) (cpu_online_map)
-#endif
-
 /*
  * Convert user-nice values [ -20 ... 0 ... 19 ]
  * to static priority [ MAX_RT_PRIO..MAX_PRIO-1 ],
Acked-by on v1 1/1
#5 lore raw

Re: [2.6 patch] sched.c: remove an unused macro

Quoted 11 lines · Adrian Bunk
Quoted 3 lines · Peter Williams

You missed some :-). The cpu_to_node_mask() macros don't seem to be used either.

I only searched for unused static inline functions (since this was relatively easy).

But your comment seems to be correct, and below is the patch that removes the cpu_to_node_mask macros.

Ingo

#6 lore raw

Re: [2.6 patch] sched.c: remove an unused macro

Quoted 7 lines · Ingo Molnar
Quoted 4 lines · Adrian Bunk
Quoted 1 line · Peter Williams

You missed some :-). The cpu_to_node_mask() macros don't seem to be used either.

Quoted 8 lines
Quoted 4 lines

I only searched for unused static inline functions (since this was relatively easy).

But your comment seems to be correct, and below is the patch that removes the cpu_to_node_mask macros.

Yep, this and the last both look fine to me too.