Skip to contentSkip to conversation

fbdev: Convert MODULE_PARM to module_param in neofb

PATCH Randy.Dunlap 1 participant 1 message Oct 30, 2004 1 message not in the archive

lore
Share & tools
lore

A message that is not in the archive (sent off-list or not yet received): [email protected]

#1 lore raw
Quoted 19 lines · Linux Kernel Mailing List

ChangeSet 1.2337.1.21, 2004/10/29 13:24:51-07:00, [email protected]

[PATCH] fbdev: Convert MODULE_PARM to module_param in neofb Convert MODULE_PARM to module_param in neofb

diff -Nru a/drivers/video/neofb.c b/drivers/video/neofb.c

(quoted diff) +3 -3
@@ -100,18 +100,18 @@
 MODULE_AUTHOR("(c) 2001-2002  Denis Oliver Kropp <[email protected]>");
 MODULE_LICENSE("GPL");
 MODULE_DESCRIPTION("FBDev driver for NeoMagic PCI Chips");
-MODULE_PARM(internal, "i");
+module_param(internal, bool, 0);
 MODULE_PARM_DESC(internal, "Enable output on internal LCD Display.");
-MODULE_PARM(external, "i");
+module_param(external, bool, 0);
 MODULE_PARM_DESC(external, "Enable output on external CRT.");
-MODULE_PARM(libretto, "i");
+module_param(libretto, bool, 0);
 MODULE_PARM_DESC(libretto, "Force Libretto 100/110 800x480 LCD.");

Review line 115

Quoted 10 lines
(quoted diff) +3 -3
-MODULE_PARM(nostretch, "i");
+module_param(nostretch, bool, 0);
 MODULE_PARM_DESC(nostretch,
 		 "Disable stretching of modes smaller than LCD.");
-MODULE_PARM(nopciburst, "i");
+module_param(nopciburst, bool, 0);
 MODULE_PARM_DESC(nopciburst, "Disable PCI burst mode.");
-MODULE_PARM(mode_option, "s");
+module_param(mode_option, charp, 0);
 MODULE_PARM_DESC(mode_option, "Preferred video mode ('640x480-8@60', etc)");

Since neofb_setup() still parses options, what does this do? Provide 2 ways of passing options/arguments?

Same questions for intelfb and i810fb.

Oh, is it this?
neofb_setup() is used for non-modular option parsing,
and module_param() is used for modular or non-modular option parsing.

IOW, using neofb_setup() for option parsing maintains some backward compatibility for options?

Signature · 1 line
~Randy