Skip to contentSkip to conversation

RFC: [2.6 patch] Eicon: disable debuglib for modules

PATCH Adrian Bunk 2 participants 5 messages Oct 30, 2004 – Feb 9, 2005

lore
Share & tools
lore
#0 lore raw

Is there a good reason why debuglib is enabled for modules?

If not, I'd propose the patch below to disable it.

drivers/isdn/hardware/eicon/platform.h renamed from drivers/isdn/hardware/eicon/platform.h.old +1 -3
@@ -35,10 +35,8 @@
 
 #include "cardtype.h"
 
-/* activate debuglib for modules only */
-#ifndef MODULE
+/* disable debuglib */
 #define DIVA_NO_DEBUGLIB
-#endif
 
 #define DIVA_INIT_FUNCTION  __init
 #define DIVA_EXIT_FUNCTION  __exit
#1 lore raw
Quoted 1 line · Adrian Bunk

Is there a good reason why debuglib is enabled for modules?

Yes.
Without it, there would be no possibility to use the maintainance module to debug the isdn/card/capi interaction.

Quoted 1 line

If not, I'd propose the patch below to disable it.

I have to disagree. This patch would disable a major feature of the diva driver collection.

Armin

Quoted 17 lines
drivers/isdn/hardware/eicon/platform.h renamed from drivers/isdn/hardware/eicon/platform.h.old +1 -3
@@ -35,10 +35,8 @@
 
 #include "cardtype.h"
 
-/* activate debuglib for modules only */
-#ifndef MODULE
+/* disable debuglib */
 #define DIVA_NO_DEBUGLIB
-#endif
 
 #define DIVA_INIT_FUNCTION  __init
 #define DIVA_EXIT_FUNCTION  __exit
#2 lore raw
Quoted 10 lines
Quoted 1 line

Is there a good reason why debuglib is enabled for modules?

Yes.
Without it, there would be no possibility to use the maintainance module to debug the isdn/card/capi interaction.

Quoted 1 line

If not, I'd propose the patch below to disable it.

I have to disagree. This patch would disable a major feature of the diva driver collection.

How do I enable this maintainance module in the kernel?

Quoted 1 line

Armin

cu
Adrian

Signature · 4 lines
       "Is there not promise of rain?" Ling Tan asked suddenly out
        of the darkness. There had been need of rain for many days.
       "Only a promise," Lao Er said.
                                       Pearl S. Buck - Dragon Seed
#3 lore raw
Quoted 6 lines · Adrian Bunk
Quoted 6 lines
Quoted 1 line

Is there a good reason why debuglib is enabled for modules?

Yes.
Without it, there would be no possibility to use the maintainance module to debug the isdn/card/capi interaction.

Quoted 6 lines
Quoted 4 lines
Quoted 1 line

If not, I'd propose the patch below to disable it.

I have to disagree. This patch would disable a major feature of the diva driver collection.

How do I enable this maintainance module in the kernel?

The option 'DIVA Maint driver support' enables this module.
When the module is loaded, all diva modules provide trace logs to that module. Using the user-space utility 'divactrl' you can set e.g. trace masks and read the messages.

Armin

#4 lore raw
In reply to Adrian Bunk
Quoted 6 lines · Adrian Bunk
Quoted 6 lines
Quoted 1 line

Is there a good reason why debuglib is enabled for modules?

Yes.
Without it, there would be no possibility to use the maintainance module to debug the isdn/card/capi interaction.

Quoted 6 lines
Quoted 4 lines
Quoted 1 line

If not, I'd propose the patch below to disable it.

I have to disagree. This patch would disable a major feature of the diva driver collection.

How do I enable this maintainance module in the kernel?

In the 'ISDN active card' 'Eicon' section you will find the option
DIVA Maint driver support
which is only available as a module.
When the other diva drivers are compiled as modules too, they will provide all trace data to the maint module.
The userspace tool 'divactrl' then retrieves the trace data according to set trace masks.

Armin